From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94803C43457 for ; Mon, 12 Oct 2020 11:38:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C8C8206E5 for ; Mon, 12 Oct 2020 11:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXjiSmyb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388275AbgJLLit (ORCPT ); Mon, 12 Oct 2020 07:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388208AbgJLLis (ORCPT ); Mon, 12 Oct 2020 07:38:48 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D695C0613CE; Mon, 12 Oct 2020 04:38:48 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id p11so8419093pld.5; Mon, 12 Oct 2020 04:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uAr1u2AxKhyAhsPGz3HPtu7lWVnt+PlRnjUfOtRYD10=; b=eXjiSmybFzCfsLPApRdx4SqJd6Q3JXAdvU4MJPKZZ4ippGkNFfgFeYTZwyzfKdWC3N YY4Ee59ldzAAxxHe4aH1Td5dqVxdLDSGafdKsH+jgctwaG/tQBZccfYg2Xd7cpGdzQhy fkUUiKGWchxtaeuE8+U1v99g21gesrczOEHEht53nKBwa+fizLetc2lpleHUJ3jYOm1F QMF4HcPQ5uyXuV6Lge8N7UnvTP16iaUuhVuaaUhk4DU80tBdQTswwjokQViDioc3Pi/N 0n448WWUK9jaxfz/5wTa5GytQaRD4Yb4oY0mKvyOFaUUdJ0ABranwTEq/UXc10SqAA6R y3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uAr1u2AxKhyAhsPGz3HPtu7lWVnt+PlRnjUfOtRYD10=; b=kS6ICuadiDeAngrKXdqbmKMsWnI/YfLA6DL8kKwPOGBytT4IZIZFYjl85o3PTmaJlJ FI2gfA5DwTQBGlzjFDPjYpzHEpvh2iN71kjNvyURgU4DNP1e8xCXGaS2uE0f3/CoLM2W 0hEeSrwDjLQ551yUVWZsLiPU7UDISWaf5SQEtYK5k7n5US4I8pUlJYn65pomn1FLWPGY I0fzJkWLG/kD/Gx8EhW5WxeHIREdPdEc5a9MUO3oG5H2PVyYuMv/7Inc1UeTHA+5V3oP mjU5O/N3Kmm44QcGWuB+oIpfupZ4xJhixiuZdEHrP47XIQLMowFUzEJ82Zj01hClcJyw 3HYw== X-Gm-Message-State: AOAM530CrddpnBu81EdD1LoviOP84LLGiyooNSeJrjOI/F2oPmXpuHQr kFV76OszgepiiiL2zg85MhCQdDjYeW2hlD8U X-Google-Smtp-Source: ABdhPJxHiPbCY6AwdU1NepgLndb4Cc4E+OU455e+aeQtaXWusCq2n76TGY06FvHVFDAGFlriW9lX4w== X-Received: by 2002:a17:902:8698:b029:d3:b362:7342 with SMTP id g24-20020a1709028698b02900d3b3627342mr23245874plo.50.1602502728048; Mon, 12 Oct 2020 04:38:48 -0700 (PDT) Received: from localhost ([160.16.113.140]) by smtp.gmail.com with ESMTPSA id v20sm14861383pjh.5.2020.10.12.04.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 04:38:47 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Mon, 12 Oct 2020 19:29:14 +0800 To: Benjamin Poirier Cc: devel@driverdev.osuosl.org, Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" , open list Subject: Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land Message-ID: <20201012112914.xrkwi53gqvg5l6lw@Rk> References: <20201008115808.91850-1-coiby.xu@gmail.com> <20201008115808.91850-6-coiby.xu@gmail.com> <20201010080126.GC14495@f3> <20201010100002.6v54yiojnscnuxqv@Rk> <20201010134055.GA18693@f3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201010134055.GA18693@f3> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Oct 10, 2020 at 10:40:55PM +0900, Benjamin Poirier wrote: >On 2020-10-10 18:00 +0800, Coiby Xu wrote: >[...] >> > >> > Please also update drivers/staging/qlge/TODO accordingly. There is still >> > a lot of debugging code IMO (the netif_printk statements - kernel >> > tracing can be used instead of those) but this patch is a substantial >> > improvement. >> >> Thank you for the reminding! To move qlge out of staging tree would be >> interesting exercise for me:) > >If you would like to work more on the driver, I would highly suggest >getting one or two adapters to be able to test your changes. They can be >had for relatively cheap on ebay. Just search for "qle8142". Thank you for the info! Right now I don't have a desktop to install this kind of adapter. I'll get one after settling the plan for a desktop. -- Best regards, Coiby