From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14026C433E7 for ; Mon, 12 Oct 2020 21:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADE9E2076E for ; Mon, 12 Oct 2020 21:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602536870; bh=nsc/0B/+C92oHrZsEO9olnO9pqRG5a5XfkepZ2l/RUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MRL24SBw5HUcEBuTNveZiO9a7ZWFuyaD31s9Zz6YJmQLb/EJfmXdQugHrZ9m+Mdgb NW6vZKYqUl61usEUfe7ZINzpHGe9W2bg/0KscDLHb6xQjwvY4Kvz02acowLQHoygFM aOHzh6C+6b0WfmuRYlnaOXl0UfPBzRWwVkG726tk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730752AbgJLVHt (ORCPT ); Mon, 12 Oct 2020 17:07:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:43194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729366AbgJLVHt (ORCPT ); Mon, 12 Oct 2020 17:07:49 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB0B2206CA; Mon, 12 Oct 2020 21:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602536869; bh=nsc/0B/+C92oHrZsEO9olnO9pqRG5a5XfkepZ2l/RUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KBsC76aZBghbh0ORKTdxl7MNFO9Znf/gsue8NhN8c9nEj7OXUoJSbnfXUsXgvbU4G QK4s/UpqbKH2GDbIVCrVdG+NE8OZk4sAEFVoGvcycw55qQHELsgAE5xhOxYDMDgd/4 0S9Bzt5J9c7buoRYFzNPa4jouHR+P9kMtvlMt7L4= Date: Mon, 12 Oct 2020 14:07:47 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: Jonathan Lemon , Linux Kernel Network Developers , saeedm@nvidia.com, tariqt@nvidia.com, kernel-team@fb.com Subject: Re: [PATCH net-next] mlx4: handle non-napi callers to napi_poll Message-ID: <20201012140747.06e4c2dd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201008184526.3196768-1-jonathan.lemon@gmail.com> <20201011113529.23a26766@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 12 Oct 2020 09:40:51 +0300 Tariq Toukan wrote: > On Mon, 12 Oct 2020 at 05:47, Jakub Kicinski wrote: > > > > On Thu, 8 Oct 2020 11:45:26 -0700 Jonathan Lemon wrote: > > > From: Jonathan Lemon > > > > > > netcons calls napi_poll with a budget of 0 to transmit packets. > > > Handle this by: > > > - skipping RX processing > > > - do not try to recycle TX packets to the RX cache > > > > > > Signed-off-by: Jonathan Lemon > > > > Tariq, Saeed - how does this look to you? > > Reviewed-by: Tariq Toukan Applied, thanks!