From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C16C433E7 for ; Mon, 12 Oct 2020 19:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DF16214DB for ; Mon, 12 Oct 2020 19:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602529544; bh=ptha9/6vbYax2Cmn6fZT5FA9ybQKKoEsnoXVXkEp964=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xiYBl62qS3ET8PpWgnqtI1CThbetz4NzLnsZ9YQ3Z2trJ+38uB69Ripsd8xz31X4h HAH8WOvW5MTI7RrYqPht8YU96dOWpeE1hDhzdQ9XARQPJAKYUhuZxtwGhRUs3meonO l+kCUvli4xpzE2GuD887uR2wVlIMDoIGY8xLJ5mE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391579AbgJLTFi (ORCPT ); Mon, 12 Oct 2020 15:05:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:53898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391313AbgJLTEZ (ORCPT ); Mon, 12 Oct 2020 15:04:25 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EF582224A; Mon, 12 Oct 2020 19:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602529452; bh=ptha9/6vbYax2Cmn6fZT5FA9ybQKKoEsnoXVXkEp964=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VF/9wOZqEJyd4EfFju3jWAF1p64vHGeil/GCMMulJB2dM146MGCPCAsZCr967qmsD gkqlAc38WS91J9ry9rR1z5S8+VsLHLyayk/Z0/eSfL+XcE9Ut8H43esuQu9Rc/A/4C lVuE1LNgnGqOv9qymu8szaWoIRVVoGcQp1IgobG8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jamie Iles , Jeremy Linton , Andrew Lunn , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 2/6] net/fsl: quieten expected MDIO access failures Date: Mon, 12 Oct 2020 15:04:04 -0400 Message-Id: <20201012190408.3279779-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201012190408.3279779-1-sashal@kernel.org> References: <20201012190408.3279779-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jamie Iles [ Upstream commit 1ec8e74855588cecb2620b28b877c08f45765374 ] MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long boot times in a way that looks like an infinite loop when multiple busses are present. Since 0f183fd151c (net/fsl: enable extended scanning in xgmac_mdio) we perform more scanning so there are potentially more failures. Reduce the logging level to dev_dbg which is consistent with the Freescale enetc driver. Cc: Jeremy Linton Signed-off-by: Jamie Iles Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index c82c85ef5fb34..61cb4ba0005bd 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -229,7 +229,7 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum) /* Return all Fs if nothing was there */ if ((xgmac_read32(®s->mdio_stat, endian) & MDIO_STAT_RD_ER) && !priv->has_a011043) { - dev_err(&bus->dev, + dev_dbg(&bus->dev, "Error while reading PHY%d reg at %d.%hhu\n", phy_id, dev_addr, regnum); return 0xffff; -- 2.25.1