From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A87C4363A for ; Mon, 12 Oct 2020 19:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81E4721BE5 for ; Mon, 12 Oct 2020 19:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602529523; bh=6Co/gsGu6KjrXaEmBLDO2KaZP7cCA9HeWbgIWngnSbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=f+H1/HmjNgUsVt8F5s/Dpbu89+K8uOoRGIk8gbbBpP7A4FoJv3TaxyDfNtUz/n2MK D30LL0q/OPKfUCyPPjbYTry8Pw/irj1Dy1wHmFfuLYHyNxQAGxpgjltDlCuR4CQ3Uw WNZS6A+09ELwjvBZRanmVU6E+sVGpZKqSWYxhsXo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391547AbgJLTFX (ORCPT ); Mon, 12 Oct 2020 15:05:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:54360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391355AbgJLTEZ (ORCPT ); Mon, 12 Oct 2020 15:04:25 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4FBB22258; Mon, 12 Oct 2020 19:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602529461; bh=6Co/gsGu6KjrXaEmBLDO2KaZP7cCA9HeWbgIWngnSbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PxwBuextDRCxXPn70CXoJ7VgzsyXedP2YuPD6mChXKYftbysecmb9JNKz/oilwc3i 1weWZk3keGa6/IbhWgVEK696T4uvUkWex/JfELrfUkyqan7XLM4bEW+SaZcd1Zcqfh 1SC4BMW2sWJECVP73abziNTPoLE342rq+IAWWj0U= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jamie Iles , Jeremy Linton , Andrew Lunn , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 2/6] net/fsl: quieten expected MDIO access failures Date: Mon, 12 Oct 2020 15:04:14 -0400 Message-Id: <20201012190418.3279866-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201012190418.3279866-1-sashal@kernel.org> References: <20201012190418.3279866-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jamie Iles [ Upstream commit 1ec8e74855588cecb2620b28b877c08f45765374 ] MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long boot times in a way that looks like an infinite loop when multiple busses are present. Since 0f183fd151c (net/fsl: enable extended scanning in xgmac_mdio) we perform more scanning so there are potentially more failures. Reduce the logging level to dev_dbg which is consistent with the Freescale enetc driver. Cc: Jeremy Linton Signed-off-by: Jamie Iles Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index a15b4a97c172d..d407471f3be04 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -229,7 +229,7 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum) /* Return all Fs if nothing was there */ if ((xgmac_read32(®s->mdio_stat, endian) & MDIO_STAT_RD_ER) && !priv->has_a011043) { - dev_err(&bus->dev, + dev_dbg(&bus->dev, "Error while reading PHY%d reg at %d.%hhu\n", phy_id, dev_addr, regnum); return 0xffff; -- 2.25.1