netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Tom Rix <trix@redhat.com>
Cc: natechancellor@gmail.com, ndesaulniers@google.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	clang-built-linux@googlegroups.com
Subject: Re: [PATCH] ptp: ptp_clockmatrix: initialize variables
Date: Tue, 13 Oct 2020 05:40:06 -0700	[thread overview]
Message-ID: <20201013124006.GA10454@hoboy> (raw)
In-Reply-To: <05da63b8-f1f5-9195-d156-0f2e7f3ea116@redhat.com>

On Mon, Oct 12, 2020 at 09:07:30PM -0700, Tom Rix wrote:
> calling function is a print information only function that returns void.

That is fine.

> I do think not adding error handling is worth it.
> 
> I could change the return and then the calls if if you like.

How about printing the version string when readable, and otherwise
print an appropriate informative error message?

Thanks,
Richard

      reply	other threads:[~2020-10-13 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 20:09 [PATCH] ptp: ptp_clockmatrix: initialize variables trix
2020-10-12 22:01 ` Richard Cochran
2020-10-13  4:07   ` Tom Rix
2020-10-13 12:40     ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013124006.GA10454@hoboy \
    --to=richardcochran@gmail.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).