From: Jakub Kicinski <kuba@kernel.org>
To: Ayush Sawal <ayush.sawal@chelsio.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, secdev@chelsio.com
Subject: Re: [PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr
Date: Tue, 13 Oct 2020 17:31:58 -0700 [thread overview]
Message-ID: <20201013173158.4db35480@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201012065231.21269-1-ayush.sawal@chelsio.com>
On Mon, 12 Oct 2020 12:22:31 +0530 Ayush Sawal wrote:
> This patch changes the module name to "ch_ipsec" and prepends
> "ch_ipsec" string instead of "chcr" in all debug messages and function names.
>
> V1->V2:
> -Removed inline keyword from functions.
> -Removed CH_IPSEC prefix from pr_debug.
> -Used proper indentation for the continuation line of the function
> arguments.
>
> Fixes: 1b77be463929 ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
> Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
Checkpatch complains about bad indentation:
CHECK: Alignment should match open parenthesis
#282: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:408:
+static void *copy_esn_pktxt(struct sk_buff *skb,
+ struct net_device *dev,
CHECK: Alignment should match open parenthesis
#297: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:462:
+static void *copy_cpltx_pktxt(struct sk_buff *skb,
+ struct net_device *dev,
CHECK: Alignment should match open parenthesis
#312: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:506:
+static void *copy_key_cpltx_pktxt(struct sk_buff *skb,
+ struct net_device *dev,
CHECK: Alignment should match open parenthesis
#328: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:554:
+static void *ch_ipsec_crypto_wreq(struct sk_buff *skb,
+ struct net_device *dev,
prev parent reply other threads:[~2020-10-14 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 6:52 [PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr Ayush Sawal
2020-10-14 0:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013173158.4db35480@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=ayush.sawal@chelsio.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).