From: Jakub Kicinski <kuba@kernel.org>
To: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
Cc: <davem@davemloft.net>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
<jiri@mellanox.com>, <idosch@mellanox.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bridge@lists.linux-foundation.org>,
<UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.
Date: Wed, 14 Oct 2020 16:33:48 -0700 [thread overview]
Message-ID: <20201014163348.2f99e349@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201012140428.2549163-9-henrik.bjoernlund@microchip.com>
On Mon, 12 Oct 2020 14:04:26 +0000 Henrik Bjoernlund wrote:
> + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_SEQ_NO_UPDATE,
> + mep->cc_ccm_tx_info.seq_no_update))
> + goto nla_put_failure;
> +
> + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PERIOD,
> + mep->cc_ccm_tx_info.period))
> + goto nla_put_failure;
> +
> + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_IF_TLV,
> + mep->cc_ccm_tx_info.if_tlv))
> + goto nla_put_failure;
> +
> + if (nla_put_u8(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_IF_TLV_VALUE,
> + mep->cc_ccm_tx_info.if_tlv_value))
> + goto nla_put_failure;
> +
> + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV,
> + mep->cc_ccm_tx_info.port_tlv))
> + goto nla_put_failure;
> +
> + if (nla_put_u8(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV_VALUE,
> + mep->cc_ccm_tx_info.port_tlv_value))
> + goto nla_put_failure;
Consider collapsing writing related attrs in a nest into a single
if statement:
if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_SEQ_NO_UPDATE,
mep->cc_ccm_tx_info.seq_no_update) ||
nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PERIOD,
mep->cc_ccm_tx_info.period) ||
...
next prev parent reply other threads:[~2020-10-14 23:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:04 [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 01/10] net: bridge: extend the process of special frames Henrik Bjoernlund
2020-10-14 10:50 ` Nikolay Aleksandrov
2020-10-12 14:04 ` [PATCH net-next v5 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete Henrik Bjoernlund
2020-10-14 23:00 ` Jakub Kicinski
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-14 23:30 ` Jakub Kicinski
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added Henrik Bjoernlund
2020-10-14 22:59 ` Jakub Kicinski
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added Henrik Bjoernlund
2020-10-14 23:16 ` Jakub Kicinski
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-14 23:26 ` Jakub Kicinski
2020-10-15 11:27 ` Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 07/10] bridge: cfm: Netlink SET configuration Interface Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 08/10] bridge: cfm: Netlink GET " Henrik Bjoernlund
2020-10-14 10:54 ` Nikolay Aleksandrov
2020-10-15 11:24 ` henrik.bjoernlund
2020-10-14 23:33 ` Jakub Kicinski [this message]
2020-10-15 11:24 ` Henrik Bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface Henrik Bjoernlund
2020-10-14 11:24 ` Nikolay Aleksandrov
2020-10-15 11:33 ` henrik.bjoernlund
2020-10-12 14:04 ` [PATCH net-next v5 10/10] bridge: cfm: Netlink Notifications Henrik Bjoernlund
2020-10-14 22:58 ` [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Jakub Kicinski
2020-10-15 11:32 ` Henrik Bjoernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014163348.2f99e349@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=henrik.bjoernlund@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).