From: Jakub Kicinski <kuba@kernel.org>
To: Hoang Huu Le <hoang.h.le@dektech.com.au>
Cc: tipc-discussion@lists.sourceforge.net, jmaloy@redhat.com,
maloy@donjonn.com, ying.xue@windriver.com,
netdev@vger.kernel.org
Subject: Re: [net] tipc: re-configure queue limit for broadcast link
Date: Wed, 14 Oct 2020 17:47:16 -0700 [thread overview]
Message-ID: <20201014174716.44b4fca3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201013061810.77866-1-hoang.h.le@dektech.com.au>
On Tue, 13 Oct 2020 13:18:10 +0700 Hoang Huu Le wrote:
> The queue limit of the broadcast link is being calculated base on initial
> MTU. However, when MTU value changed (e.g manual changing MTU on NIC
> device, MTU negotiation etc.,) we do not re-calculate queue limit.
> This gives throughput does not reflect with the change.
>
> So fix it by calling the function to re-calculate queue limit of the
> broadcast link.
>
> Acked-by: Jon Maloy <jmaloy@redhat.com>
> Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au>
> ---
> net/tipc/bcast.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 940d176e0e87..c77fd13e2777 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -108,6 +108,7 @@ static void tipc_bcbase_select_primary(struct net *net)
> {
> struct tipc_bc_base *bb = tipc_bc_base(net);
> int all_dests = tipc_link_bc_peers(bb->link);
> + int max_win = tipc_link_max_win(bb->link);
> int i, mtu, prim;
>
> bb->primary_bearer = INVALID_BEARER_ID;
> @@ -121,8 +122,11 @@ static void tipc_bcbase_select_primary(struct net *net)
> continue;
>
> mtu = tipc_bearer_mtu(net, i);
> - if (mtu < tipc_link_mtu(bb->link))
> + if (mtu < tipc_link_mtu(bb->link)) {
> tipc_link_set_mtu(bb->link, mtu);
> + tipc_link_set_queue_limits(bb->link, max_win,
> + max_win);
Is max/max okay here? Other places seem to use BCLINK_WIN_MIN.
> + }
> bb->bcast_support &= tipc_bearer_bcast_support(net, i);
> if (bb->dests[i] < all_dests)
> continue;
next prev parent reply other threads:[~2020-10-15 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 6:18 [net] tipc: re-configure queue limit for broadcast link Hoang Huu Le
2020-10-15 0:47 ` Jakub Kicinski [this message]
2020-10-15 2:25 ` Hoang Huu Le
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014174716.44b4fca3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=hoang.h.le@dektech.com.au \
--cc=jmaloy@redhat.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).