From: Jakub Kicinski <kuba@kernel.org>
To: Herat Ramani <herat@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, rahul@chelsio.com,
dt@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: handle 4-tuple PEDIT to NAT mode translation
Date: Wed, 14 Oct 2020 18:24:59 -0700 [thread overview]
Message-ID: <20201014182459.68896a93@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201013093129.321-1-herat@chelsio.com>
On Tue, 13 Oct 2020 15:01:29 +0530 Herat Ramani wrote:
> The 4-tuple NAT offload via PEDIT always overwrites all the 4-tuple
> fields even if they had not been explicitly enabled. If any fields in
> the 4-tuple are not enabled, then the hardware overwrites the
> disabled fields with zeros, instead of ignoring them.
>
> So, add a parser that can translate the enabled 4-tuple PEDIT fields
> to one of the NAT mode combinations supported by the hardware and
> hence avoid overwriting disabled fields to 0. Any rule with
> unsupported NAT mode combination is rejected.
>
> Signed-off-by: Herat Ramani <herat@chelsio.com>
Looks good, applied, but to net.
Not rejecting unsupported configurations is a bug.
Unless you tell me otherwise I'll also queue this for stable.
Thanks!
prev parent reply other threads:[~2020-10-15 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:31 [PATCH net-next] cxgb4: handle 4-tuple PEDIT to NAT mode translation Herat Ramani
2020-10-15 1:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014182459.68896a93@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=herat@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rahul@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).