From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ru8x=DW=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5D7BEC433E7
	for <netdev@archiver.kernel.org>; Thu, 15 Oct 2020 17:34:38 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 07C0022243
	for <netdev@archiver.kernel.org>; Thu, 15 Oct 2020 17:34:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1602783277;
	bh=DNxvAuV7cKNsPEncClCJJJ0vr4kkwu9AJqh2X91MJ+I=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=pOvOFe4oeZVb3dbBqkyczK/irWL6jTgtTdptGR1iuD5G4hoFKKAMzsIGPyle2mOLP
	 xXS4rS8N+ubi9apbnKy9wRHNAMQO2F1DMIjkRjw5NuKORWerJPzX9p+JhrYCzOnLAf
	 pWxqUZSYcfRpFLIL00t9B8NC/MafVDat1jd6Y3kM=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731217AbgJORee (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 15 Oct 2020 13:34:34 -0400
Received: from mail.kernel.org ([198.145.29.99]:43468 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731190AbgJORee (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 15 Oct 2020 13:34:34 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 51DFC2225F;
        Thu, 15 Oct 2020 17:34:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1602783274;
        bh=DNxvAuV7cKNsPEncClCJJJ0vr4kkwu9AJqh2X91MJ+I=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Ma63it46MNeYoPlFyYS5c1K5Cr4yl4b0mvpITcv+TdQSvEqmopd6R4HZanFaS0Ga3
         Sg9uHJdGQ51/ZZRXYNcxvJph/r1CpZQxyJWJzJhM7/JtRPWs7mYClAwKFR7Swjx7/8
         48jSLBH9u8JSFCL2ndfp0McKVKoUbsT8Lq397YIg=
Date:   Thu, 15 Oct 2020 10:34:31 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
Cc:     <davem@davemloft.net>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
        <jiri@mellanox.com>, <idosch@mellanox.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <bridge@lists.linux-foundation.org>,
        <UNGLinuxDriver@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET
 configuration Interface.
Message-ID: <20201015103431.25d66c8b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201015115418.2711454-8-henrik.bjoernlund@microchip.com>
References: <20201015115418.2711454-1-henrik.bjoernlund@microchip.com>
        <20201015115418.2711454-8-henrik.bjoernlund@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote:
> +	[IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL]	 = {
> +	.type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 },

	NLA_POLICY_MAX(NLA_U32, 7)

Also why did you keep the validation in the code in patch 4?