From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF43C433E7 for ; Fri, 16 Oct 2020 17:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42A81208E4 for ; Fri, 16 Oct 2020 17:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602870535; bh=NGn+uaxc51RgqjFOnKMIZpDJGbHocddGNfqOufHBeV8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Da3UpUeN7YWDhvTYgzqNwxwjNzDyy/aX1uJjWeZEZ5p3oidKEdNIaj1+VVhpK1777 AMDAyjhJ89qD08abpxtR3OeWu/JhhnWUKBu8RRKpCAKTh4f47tb54q2Q1eU8VIWu7D bYw672FdiCeZNc31vwh8BvzZ7yd8DvLkX4dNAh2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732262AbgJPRsy (ORCPT ); Fri, 16 Oct 2020 13:48:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:44714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731589AbgJPRsy (ORCPT ); Fri, 16 Oct 2020 13:48:54 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C69D20709; Fri, 16 Oct 2020 17:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602870533; bh=NGn+uaxc51RgqjFOnKMIZpDJGbHocddGNfqOufHBeV8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dtDx1mwHKrmBsQH/Z4I6b+MYsueRr9/Il34OisnTuOlG8hQuRmbcFkOwFF0ovgu57 GOngRxQissD7Vt05B/29WSn6jIOhsvFpg9S4npU0aqeFwVVMnQ8S/uKk7pyRc3OtvV ftPPcvST7ETpnbUmqNsIl4q6S/npjEkmGXiobfkU= Date: Fri, 16 Oct 2020 10:48:51 -0700 From: Jakub Kicinski To: sundeep subbaraya Cc: David Miller , netdev@vger.kernel.org, rsaladi2@marvell.com, Sunil Kovvuri Goutham , Subbaraya Sundeep Subject: Re: [net-next PATCH 06/10] octeontx2-af: Add NIX1 interfaces to NPC Message-ID: <20201016104851.01ac62f4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <1602584792-22274-1-git-send-email-sundeep.lkml@gmail.com> <1602584792-22274-7-git-send-email-sundeep.lkml@gmail.com> <20201014194804.1e3b57ae@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201015083251.10bc1aaf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 16 Oct 2020 08:59:43 +0530 sundeep subbaraya wrote: > On Thu, Oct 15, 2020 at 9:02 PM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 17:53:07 +0530 sundeep subbaraya wrote: > > > Hi Jakub, > > > > > > On Thu, Oct 15, 2020 at 8:18 AM Jakub Kicinski wrote: > > > > > > > > On Tue, 13 Oct 2020 15:56:28 +0530 sundeep.lkml@gmail.com wrote: > > > > > -static const struct npc_mcam_kex npc_mkex_default = { > > > > > +static struct npc_mcam_kex npc_mkex_default = { > > > > > .mkex_sign = MKEX_SIGN, > > > > > .name = "default", > > > > > .kpu_version = NPC_KPU_PROFILE_VER, > > > > > > > > Why is this no longer constant? Are you modifying global data based > > > > on the HW discovered in the system? > > > > > > Yes. Due to an errata present on earlier silicons > > > npc_mkex_default.keyx_cfg[NIX_INTF_TX] > > > and npc_mkex_default.keyx_cfg[NIX_INTF_RX] needs to be identical. > > > > Does this run on the SoC? Is there no possibility that the same kernel > > will have to drive two different pieces of hardware? > > If kernel runs on SoC with errata present then > npc_mkex_default.keyx_cfg[NIX_INTF_TX] > is modified to be same as npc_mkex_default.keyx_cfg[NIX_INTF_RX]. And if errata > is not applicable to SoC then npc_mkex_default.keyx_cfg[NIX_INTF_TX] > is unchanged and the values present in TX and RX are programmed to TX and RX > interface registers. Let me rephrase the question - can the AF driver only run on the SoC or are there configurations in which host can control the AF? I see that Kconfig depends on ARM64 but is that what you choose to support or a HW limitation?