From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: point out the tail taggers
Date: Fri, 16 Oct 2020 19:56:51 +0300 [thread overview]
Message-ID: <20201016165651.mknc4djwhjg3t5gh@skbuf> (raw)
In-Reply-To: <20201016162800.7696-1-ceggers@arri.de>
Hi Christian,
On Fri, Oct 16, 2020 at 06:28:00PM +0200, Christian Eggers wrote:
> From a recent commit with the same summary:
>
> "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
> KSZ9893 switches also use tail tags."
>
> Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the
> original commit.
>
> Fixes: 7a6ffe764be3 [net] ("net: dsa: point out the tail taggers")
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
The idea is perfect but the commit isn't.
First of all, put this in your .gitconfig.
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
Now if you run
"git show 7a6ffe764be35af0527d8cfd047945e8f8797ddf --pretty=fixes",
you'll see:
Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers")
Notice how there's no [net] tag?
People complain when the format of the Fixes: tag is not standardized.
Secondly, can you please come up with a commit description that is
_different_ from the commit you're fixing? As a backporter I would hate
to have 2 commits with the same title, I would surely mess them up.
How about:
net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags
next prev parent reply other threads:[~2020-10-16 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 16:28 [PATCH net] net: dsa: point out the tail taggers Christian Eggers
2020-10-16 16:46 ` Florian Fainelli
2020-10-16 16:56 ` Vladimir Oltean [this message]
2020-10-16 17:25 ` kernel test robot
2020-10-16 17:33 ` Vladimir Oltean
2020-10-16 20:14 ` Andrew Lunn
2020-10-16 20:19 ` Vladimir Oltean
2020-10-16 21:03 ` Andrew Lunn
2020-10-16 21:16 ` Vladimir Oltean
2020-10-16 21:33 ` Vladimir Oltean
2020-10-16 22:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016165651.mknc4djwhjg3t5gh@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ceggers@arri.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).