From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9659FC43457 for ; Sat, 17 Oct 2020 05:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ADB820791 for ; Sat, 17 Oct 2020 05:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411860AbgJQFiW (ORCPT ); Sat, 17 Oct 2020 01:38:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:41860 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392570AbgJQFiW (ORCPT ); Sat, 17 Oct 2020 01:38:22 -0400 IronPort-SDR: llpWoGz3ausfJPWoqr7tZ4XMH0a1k5v+bEwN/q8WZ4Ub2/TF81OlWBI+NUAZFKTuqGvVvGG0I0 SBVMf5Vu0Z8w== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="153636519" X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="153636519" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 17:35:01 -0700 IronPort-SDR: Q4TUQpLRhrUKKVN5Spl62aIu9r1QZwd83TmEaFRVHdUW+Ja41cU/hoXpVKtP6uRHym8QOrAuOa xVzPAwQgHS5Q== X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="331325349" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.117.85]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 17:35:00 -0700 Date: Fri, 16 Oct 2020 17:34:58 -0700 From: Jesse Brandeburg To: Jakub Kicinski Cc: Ian Rogers , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , "David S. Miller" , Igor Russkikh , Mark Starovoytov , Horatiu Vultur , Antoine Tenart , "Toke =?ISO-8859-1?Q?H=F8ila?= =?ISO-8859-1?Q?nd-J=F8rgensen\?=" , Nikolay Aleksandrov , Roopa Prabhu , Jiri Pirko , Vlad Buslov , Ido Schimmel , Alexandre Cassen , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h Message-ID: <20201016173458.00000597@intel.com> In-Reply-To: <20201016143201.0c12c03b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20201015223119.1712121-1-irogers@google.com> <20201016142348.0000452b@intel.com> <20201016143201.0c12c03b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comments without explaining why/where there might be > > a replacement or why the comments are useless. I now see that you're > > adding actual kdoc which is good, except for the part where > > you don't put kdoc on all the structures. > > Note that he's just syncing the uAPI headers to tools/ > > The source of the change is here: > > 78a3ea555713 ("net: remove comments on struct rtnl_link_stats") > 0db0c34cfbc9 ("net: tighten the definition of interface statistics") Thanks Kuba, I'm not trying to be a hard ass, but the commit message didn't say why he's making the change, and if I bisect back to this and see "sync" as the commit message, I think I'd be stuck chasing "sync to what?" I guess that his changelog could just say what you said? Proposed: Sync the uAPI headers so that userspace and the kernel match. These changes match the updates to the files in the tools directory that were already updated by commits: 78a3ea555713 ("net: remove comments on struct rtnl_link_stats") 0db0c34cfbc9 ("net: tighten the definition of interface statistics")