Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes
@ 2020-10-16  9:41 Maxim Kochetkov
  2020-10-16 20:18 ` Vladimir Oltean
  0 siblings, 1 reply; 2+ messages in thread
From: Maxim Kochetkov @ 2020-10-16  9:41 UTC (permalink / raw)
  To: netdev
  Cc: Vladimir Oltean, Horatiu Vultur, Florian Fainelli,
	Alexandre Belloni, David S . Miller, Maxim Kochetkov

The VSC9953 Seville switch has 2 megabits of buffer split into 4360
words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
2 megabits is (2048 / 8) * 1024 = 256 * 1024.

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
---
 drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
index 9e9fd19e1d00..e2cd49eec037 100644
--- a/drivers/net/dsa/ocelot/seville_vsc9953.c
+++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
@@ -1010,7 +1010,7 @@ static const struct felix_info seville_info_vsc9953 = {
 	.vcap_is2_keys		= vsc9953_vcap_is2_keys,
 	.vcap_is2_actions	= vsc9953_vcap_is2_actions,
 	.vcap			= vsc9953_vcap_props,
-	.shared_queue_sz	= 2048 * 1024,
+	.shared_queue_sz	= 256 * 1024,
 	.num_mact_rows		= 2048,
 	.num_ports		= 10,
 	.mdio_bus_alloc		= vsc9953_mdio_bus_alloc,
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes
  2020-10-16  9:41 [PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes Maxim Kochetkov
@ 2020-10-16 20:18 ` Vladimir Oltean
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Oltean @ 2020-10-16 20:18 UTC (permalink / raw)
  To: Maxim Kochetkov
  Cc: netdev, Horatiu Vultur, Florian Fainelli, Alexandre Belloni,
	David S . Miller

On Fri, Oct 16, 2020 at 12:41:55PM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
> ---

Maxim, networking maintainers apply patches on the master branch of one
of the 2 trees:
- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git if
  it's a new feature
- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git if it's
  a bug fix

Your patch applies to neither of these trees.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16  9:41 [PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes Maxim Kochetkov
2020-10-16 20:18 ` Vladimir Oltean

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git