From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39097C433DF for ; Sun, 18 Oct 2020 18:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8E2722263 for ; Sun, 18 Oct 2020 18:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603044144; bh=feic7OW+VyP07n6rT5G/mGbcB8BcQOi+AE4DjgEgk6U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2MkTmw4IC0F0XrWMiiNO+NaAHoxsYem1onIbRlaK+dQC1JIr0cu4Cbt4W5fhEuVqu QiAb05qtYiOQPgTKm9+JKhzs0Rbjgul07QJH8LRa6lCdk0LzYRtAsxiBAX6c9o8rA5 gyx0oDHrApGkTCSYdQTvGWh2wX24BdgOTm0yaMDU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgJRSCW (ORCPT ); Sun, 18 Oct 2020 14:02:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:39660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgJRSCV (ORCPT ); Sun, 18 Oct 2020 14:02:21 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 080B72067C; Sun, 18 Oct 2020 18:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603044141; bh=feic7OW+VyP07n6rT5G/mGbcB8BcQOi+AE4DjgEgk6U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SFUkMrYbqy37cPD+xvHHi7ZHxclEIpncPW4y2Dfx+jP0PVB7ruBl4tZHkN1puZlaM bkqwxatBQNBFBj+0InP4RNxuL8G+o/G9nrJyustINrWj7Zah0arrlrdnAdIPCio9H5 3w9TGpzyinrqzhFnN+myr9ys4ONK24Wl+cHKoD2A= Date: Sun, 18 Oct 2020 11:02:19 -0700 From: Jakub Kicinski To: Heiner Kallweit Cc: Eric Dumazet , Thomas Gleixner , Eric Dumazet , David Miller , "netdev@vger.kernel.org" , LKML Subject: Re: Remove __napi_schedule_irqoff? Message-ID: <20201018110219.1b635ad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <92aed1ab-efa3-c667-7f20-8a2b8fc67469@gmail.com> References: <01af7f4f-bd05-b93e-57ad-c2e9b8726e90@gmail.com> <20201017162949.0a6dd37a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <668a1291-e7f0-ef71-c921-e173d4767a14@gmail.com> <20201018101947.419802df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <92aed1ab-efa3-c667-7f20-8a2b8fc67469@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 18 Oct 2020 19:57:53 +0200 Heiner Kallweit wrote: > > Dunno how acceptable this is to run in an IRQ handler on RT.. > > If I understand this code right then it's not a loop that actually > waits for something. It just retries if the value of n->state has > changed in between. So I don't think we'll ever see the loop being > executed more than twice. Right, but WCET = inf. IDK if that's acceptable.