From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: sven.auhagen@voleatech.de
Cc: anthony.l.nguyen@intel.com, davem@davemloft.net,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com,
sandeep.penigalapati@intel.com, brouer@redhat.com
Subject: Re: [PATCH v2 0/6] igb: xdp patches followup
Date: Sun, 18 Oct 2020 15:39:51 +0200 [thread overview]
Message-ID: <20201018133951.GB34104@ranger.igk.intel.com> (raw)
In-Reply-To: <20201017071238.95190-1-sven.auhagen@voleatech.de>
On Sat, Oct 17, 2020 at 09:12:32AM +0200, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <sven.auhagen@voleatech.de>
>
> This patch series addresses some of the comments that came back
> after the igb XDP patch was accepted.
> Most of it is code cleanup.
> The last patch contains a fix for a tx queue timeout
> that can occur when using xdp.
>
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
Sorry for not getting back at v1 discussion, I took some time off.
For the series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Couple nits:
- you don't need SOB line within cover letter, I suppose
- next time please specify the tree in the subject that you're targetting
this set to land; is it net or net-next? net-next is currently closed so
you probably would have to come back with this once it will be open
again
- SOB line should be at the end of tags within commit message of patch;
I'm saying 'should' because I'm not sure if it's hard requirement.
>
> Change from v1:
> * Drop patch 5 as the igb_rx_frame_truesize won't match
> * Fix typo in comment
> * Add Suggested-by and Reviewed-by tags
> * Add how to avoid transmit queue timeout in xdp path
> is fixed in the commit message
>
> Sven Auhagen (6):
> igb: XDP xmit back fix error code
> igb: take vlan double header into account
> igb: XDP extack message on error
> igb: skb add metasize for xdp
> igb: use xdp_do_flush
> igb: avoid transmit queue timeout in xdp path
>
> drivers/net/ethernet/intel/igb/igb.h | 5 ++++
> drivers/net/ethernet/intel/igb/igb_main.c | 32 +++++++++++++++--------
> 2 files changed, 26 insertions(+), 11 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-10-18 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 7:12 [PATCH v2 0/6] igb: xdp patches followup sven.auhagen
2020-10-17 7:12 ` [PATCH v2 1/6] igb: XDP xmit back fix error code sven.auhagen
2020-10-17 7:12 ` [PATCH v2 2/6] igb: take vlan double header into account sven.auhagen
2020-10-17 7:12 ` [PATCH v2 3/6] igb: XDP extack message on error sven.auhagen
2020-10-17 7:12 ` [PATCH v2 4/6] igb: skb add metasize for xdp sven.auhagen
2020-10-17 7:12 ` [PATCH v2 5/6] igb: use xdp_do_flush sven.auhagen
2020-10-17 7:12 ` [PATCH v2 6/6] igb: avoid transmit queue timeout in xdp path sven.auhagen
2020-10-18 13:28 ` Maciej Fijalkowski
2020-10-18 13:39 ` Maciej Fijalkowski [this message]
2020-10-18 19:03 ` [PATCH v2 0/6] igb: xdp patches followup Jakub Kicinski
2020-10-19 5:43 ` Sven Auhagen
2020-10-19 5:43 ` Sven Auhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018133951.GB34104@ranger.igk.intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sandeep.penigalapati@intel.com \
--cc=sassmann@redhat.com \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).