From: Jakub Kicinski <kuba@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Remove __napi_schedule_irqoff?
Date: Mon, 19 Oct 2020 10:55:16 -0700 [thread overview]
Message-ID: <20201019105516.4fae562c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <87ft6aa4k7.fsf@nanos.tec.linutronix.de>
On Mon, 19 Oct 2020 12:33:12 +0200 Thomas Gleixner wrote:
> On Sun, Oct 18 2020 at 10:19, Jakub Kicinski wrote:
> > On Sun, 18 Oct 2020 10:20:41 +0200 Heiner Kallweit wrote:
> >> >> Otherwise a non-solution could be to make IRQ_FORCED_THREADING
> >> >> configurable.
> >> >
> >> > I have to say I do not understand why we want to defer to a thread the
> >> > hard IRQ that we use in NAPI model.
> >> >
> >> Seems like the current forced threading comes with the big hammer and
> >> thread-ifies all hard irq's. To avoid this all NAPI network drivers
> >> would have to request the interrupt with IRQF_NO_THREAD.
>
> In a !RT kernel, forced threading (via commandline option) is mostly a
> debug aid. It's pretty useful when something crashes in hard interrupt
> context which usually takes the whole machine down. It's rather unlikely
> to be used on production systems, and if so then the admin surely should
> know what he's doing.
>
> > Right, it'd work for some drivers. Other drivers try to take spin locks
> > in their IRQ handlers.
>
> I checked a few which do and some of these spinlocks just protect
> register access and are not used for more complex serialization. So
> these could be converted to raw spinlocks because their scope is short
> and limited. But yes, you are right that this might be an issue in
> general.
>
> > What gave me a pause was that we have a busy loop in napi_schedule_prep:
> >
> > bool napi_schedule_prep(struct napi_struct *n)
> > {
> > unsigned long val, new;
> >
> > do {
> > val = READ_ONCE(n->state);
> > if (unlikely(val & NAPIF_STATE_DISABLE))
> > return false;
> > new = val | NAPIF_STATE_SCHED;
> >
> > /* Sets STATE_MISSED bit if STATE_SCHED was already set
> > * This was suggested by Alexander Duyck, as compiler
> > * emits better code than :
> > * if (val & NAPIF_STATE_SCHED)
> > * new |= NAPIF_STATE_MISSED;
> > */
> > new |= (val & NAPIF_STATE_SCHED) / NAPIF_STATE_SCHED *
> > NAPIF_STATE_MISSED;
> > } while (cmpxchg(&n->state, val, new) != val);
> >
> > return !(val & NAPIF_STATE_SCHED);
> > }
> >
> >
> > Dunno how acceptable this is to run in an IRQ handler on RT..
>
> In theory it's bad, but I don't think it's a big deal in reality.
Awesome, thanks for advice and clearing things up!
Let me apply Heiner's IRQF_NO_THREAD patch, then.
next prev parent reply other threads:[~2020-10-19 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 13:45 Remove __napi_schedule_irqoff? Heiner Kallweit
2020-10-17 23:29 ` Jakub Kicinski
2020-10-18 8:02 ` Eric Dumazet
2020-10-18 8:20 ` Heiner Kallweit
2020-10-18 17:19 ` Jakub Kicinski
2020-10-18 17:57 ` Heiner Kallweit
2020-10-18 18:02 ` Jakub Kicinski
2020-10-19 10:33 ` Thomas Gleixner
2020-10-19 17:55 ` Jakub Kicinski [this message]
2020-10-23 19:21 ` Grygorii Strashko
2020-10-18 9:55 ` Thomas Gleixner
2020-10-18 11:57 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019105516.4fae562c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).