From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7782AC433DF for ; Mon, 19 Oct 2020 12:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 106DB22268 for ; Mon, 19 Oct 2020 12:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbgJSMFh (ORCPT ); Mon, 19 Oct 2020 08:05:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34504 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgJSMFg (ORCPT ); Mon, 19 Oct 2020 08:05:36 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kUTuw-002UQp-6t; Mon, 19 Oct 2020 14:05:34 +0200 Date: Mon, 19 Oct 2020 14:05:34 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Vladimir Oltean , Heiner Kallweit , "netdev@vger.kernel.org" , "vivien.didelot@gmail.com" , "kuba@kernel.org" , Christian Eggers , Kurt Kanzenbach Subject: Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics Message-ID: <20201019120534.GL456889@lunn.ch> References: <20201017213611.2557565-2-vladimir.oltean@nxp.com> <06538edb-65a9-c27f-2335-9213322bed3a@gmail.com> <20201018121640.jwzj6ivpis4gh4ki@skbuf> <19f10bf4-4154-2207-6554-e44ba05eed8a@gmail.com> <20201018134843.emustnvgyby32cm4@skbuf> <2ae30988-5918-3d02-87f1-e65942acc543@gmail.com> <20201018225820.b2vhgzyzwk7vy62j@skbuf> <20201019002123.nzi2zhfak3r3lis3@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Oct 18, 2020 at 08:49:31PM -0700, Florian Fainelli wrote: > > > On 10/18/2020 5:21 PM, Vladimir Oltean wrote: > > On Sun, Oct 18, 2020 at 04:11:14PM -0700, Florian Fainelli wrote: > > > How about when used as a netconsole? We do support netconsole over DSA > > > interfaces. > > > > How? Who is supposed to bring up the master interface, and when? > > > > You are right that this appears not to work when configured on the kernel > command line: > > [ 6.836910] netpoll: netconsole: local port 4444 > [ 6.841553] netpoll: netconsole: local IPv4 address 192.168.1.10 > [ 6.847582] netpoll: netconsole: interface 'gphy' > [ 6.852305] netpoll: netconsole: remote port 9353 > [ 6.857030] netpoll: netconsole: remote IPv4 address 192.168.1.254 > [ 6.863233] netpoll: netconsole: remote ethernet address > b8:ac:6f:80:af:7e > [ 6.870134] netpoll: netconsole: device gphy not up yet, forcing it > [ 6.876428] netpoll: netconsole: failed to open gphy > [ 6.881412] netconsole: cleaning up > > looking at my test notes from 2015 when it was added, I had only tested > dynamic netconsole while the network devices have already been brought up > which is why I did not catch it. Let me see if I can fix that somehow. Hi Florian NFS root used to work, so there must be some code in the kernel to bring the master interface up. Might just need copy/pasting. Andrew