netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: David Ahern <dsahern@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@resnulli.us>,
	Shannon Nelson <snelson@pensando.io>
Subject: Re: [iproute2-next v3] devlink: display elapsed time during flash update
Date: Mon, 19 Oct 2020 12:20:40 -0700	[thread overview]
Message-ID: <20201019122040.2eaf4272@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <a6814a14af5c45fbad329b9a4f59b4a8@intel.com>

On Mon, 19 Oct 2020 19:05:34 +0000 Keller, Jacob E wrote:
> > The DEVLINK attributes are ridiculously long --
> > DEVLINK_ATTR_FLASH_UPDATE_STATUS_TIMEOUT is 40 characters -- which
> > forces really long code lines or oddly wrapped lines. Going forward
> > please consider abbreviations on name components to reduce their lengths.  
> 
> This is probably a larger discussion, since basically every devlink attribute name is long.
> 
> Jiri, Jakub, any thoughts on this? I'd like to see whatever abbreviation scheme we use be consistent.

As David said - let's keep an eye on this going forward. We already 
pushed back with Moshe's live reload work.

If you really want to make things better for this particular name
you could probably drop the word _STATUS from it.

  reply	other threads:[~2020-10-19 19:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 22:31 [iproute2-next v3] devlink: display elapsed time during flash update Jacob Keller
2020-10-15 17:11 ` Jiri Pirko
2020-10-17 15:34 ` David Ahern
2020-10-19 19:05   ` Keller, Jacob E
2020-10-19 19:20     ` Jakub Kicinski [this message]
2020-10-20  3:21       ` David Ahern
2020-10-20  6:45     ` Jiri Pirko
2020-10-20 14:32       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019122040.2eaf4272@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=snelson@pensando.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).