netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Vincent Bernat <vincent@bernat.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	netdev@vger.kernel.org,
	Andy Gospodarek <gospo@cumulusnetworks.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown
Date: Mon, 19 Oct 2020 17:53:26 -0700	[thread overview]
Message-ID: <20201019175326.0e06b89d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201017125011.2655391-1-vincent@bernat.ch>

On Sat, 17 Oct 2020 14:50:11 +0200 Vincent Bernat wrote:
> Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl
> ignores a route whose interface is down. It is provided as a
> per-interface sysctl. However, while a "all" variant is exposed, it
> was a noop since it was never evaluated. We use the usual "or" logic
> for this kind of sysctls.

> Without this patch, the two last lines would fail on H1 (the one using
> the "all" sysctl). With the patch, everything succeeds as expected.
> 
> Also document the sysctl in `ip-sysctl.rst`.
> 
> Fixes: 0eeb075fad73 ("net: ipv4 sysctl option to ignore routes when nexthop link is down")
> Signed-off-by: Vincent Bernat <vincent@bernat.ch>

I'm not hearing any objections, but I have two questions:
 - do you intend to merge it for 5.10 or 5.11? Because it has a fixes
   tag, yet it's marked for net-next. If we put it in 5.10 it may get
   pulled into stable immediately, knowing how things work lately.
 - we have other sysctls that use IN_DEV_CONF_GET(), 
   e.g. "proxy_arp_pvlan" should those also be converted?

  reply	other threads:[~2020-10-20  0:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 12:50 [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown Vincent Bernat
2020-10-20  0:53 ` Jakub Kicinski [this message]
2020-10-20  2:56   ` David Ahern
2020-10-20  3:15     ` Jakub Kicinski
2020-10-20  6:20   ` Vincent Bernat
2020-10-20 22:55     ` Jakub Kicinski
2020-10-20  2:57 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019175326.0e06b89d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=vincent@bernat.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).