From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41213C388F7 for ; Tue, 20 Oct 2020 14:15:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E09A32098B for ; Tue, 20 Oct 2020 14:15:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="f1jw3LJM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407946AbgJTOPw (ORCPT ); Tue, 20 Oct 2020 10:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407844AbgJTOPw (ORCPT ); Tue, 20 Oct 2020 10:15:52 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F91EC061755; Tue, 20 Oct 2020 07:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zZPoxFXO5m2rbDewqd3HClJfiW/hLSLuYz3sV0fm4Cw=; b=f1jw3LJMbyiSZ/gcVvusllVjw vtADPZXiZRsd+LluEyGlt9xIvcXgabULeLfNn12nErvogtIhHrS/WeV9d8iYAO6Oq5qogXkPtBQDx 6l0vy74ftSuhCgO9vcup9a14LEtH+OX7n1j4mbBlg4+mw24CliAK2M7sBGnTLzv0YCdHjKHjMNAY/ KLhEi21F9t2SLFJI8uv3VpKuTElHj46raXTBOrFXtAS4Yjea5ELm+Jb+PsWWBQGepxBaR3B4Rgm72 MgjNZKZQ6WcOG0xQFOkaP1mDl3hSFyKA7YMo5DMEiWjYHxxFPL4tbgfbgLj+Zl0S7BOuOOf18n6mx N04qTO6Ng==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48692) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUsQO-0007aD-5X; Tue, 20 Oct 2020 15:15:40 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kUsQ9-0005LV-66; Tue, 20 Oct 2020 15:15:25 +0100 Date: Tue, 20 Oct 2020 15:15:25 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Marek Behun , Chris Packham , vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status Message-ID: <20201020141525.GD1551@shell.armlinux.org.uk> References: <20201020034558.19438-1-chris.packham@alliedtelesis.co.nz> <20201020034558.19438-2-chris.packham@alliedtelesis.co.nz> <20201020101552.GB1551@shell.armlinux.org.uk> <20201020154940.60357b6c@nic.cz> <20201020140535.GE139700@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020140535.GE139700@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: > > On Tue, 20 Oct 2020 11:15:52 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > > > > When a port is configured with 'managed = "in-band-status"' don't force > > > > the link up, the switch MAC will detect the link status correctly. > > > > > > > > Signed-off-by: Chris Packham > > > > Reviewed-by: Andrew Lunn > > > > > > I thought we had issues with the 88E6390 where the PCS does not > > > update the MAC with its results. Isn't this going to break the > > > 6390? Andrew? > > > > > > > Russell, I tested this patch on Turris MOX with 6390 on port 9 (cpu > > port) which is configured in devicetree as 2500base-x, in-band-status, > > and it works... > > > > Or will this break on user ports? > > User ports is what needs testing, ideally with an SFP. > > There used to be explicit code which when the SERDES reported link up, > the MAC was configured in software with the correct speed etc. With > the move to pcs APIs, it is less obvious how this works now, does it > still software configure the MAC, or do we have the right magic so > that the hardware updates itself. It's still there. The speed/duplex etc are read from the serdes PHY via mv88e6390_serdes_pcs_get_state(). When the link comes up, we pass the negotiated link parameters read from there to the link_up() functions. For ports where mv88e6xxx_port_ppu_updates() returns false (no external PHY) we update the port's speed and duplex setting and (currently, before this patch) force the link up. That was the behaviour before I converted the code, the one that you referred to. I had assumed the code was correct, and _none_ of the speed, duplex, nor link state was propagated from the serdes PCS to the port on the 88E6390 - hence why the code you refer to existed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!