From: "Marek Behún" <kabel@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org
Subject: russell's net-queue question
Date: Tue, 20 Oct 2020 17:15:39 +0200 [thread overview]
Message-ID: <20201020171539.27c33230@kernel.org> (raw)
Russell,
I think the following commits in your net-queue should be still made better:
7f79709b7a15 ("net: phy: pass supported PHY interface types to phylib")
eba49a289d09 ("net: phy: marvell10g: select host interface configuration")
http://git.arm.linux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=eba49a289d0959eab3dfbc0320334eb5a855ca68
http://git.arm.linux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=eba49a289d0959eab3dfbc0320334eb5a855ca68
The first one adds filling of the phydev->host_interfaces bitmap into
the phylink_sfp_connect_phy function. It should also fill this bitmap
in functions phylink_connect_phy and phylink_of_phy_connect (direct
copy of pl->config->supported_interfaces).
The reason is that phy devices may want to know what interfaces are
supported by host even if no SFP is used (Marvell 88X3310 is an exmaple
of this).
The second patch (adding mactype selection to marvell10g) can get rid
of the rate matching code, and also
should update the mv3310_update_interface code accordignly.
Should I sent you these patches updated or should I create new patches
on top of yours?
Marek
next reply other threads:[~2020-10-20 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:15 Marek Behún [this message]
2020-10-20 15:45 ` russell's net-queue question Russell King - ARM Linux admin
2020-10-21 13:48 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020171539.27c33230@kernel.org \
--to=kabel@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).