From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5105C388EC for ; Wed, 21 Oct 2020 03:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B5BF221FC for ; Wed, 21 Oct 2020 03:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603252695; bh=XBGNkaYEUqlMFMVtbOPtDEIt72DqySZrBEAbtk/WssY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Y2QwicMqVEeZyZn1tVyCi6txd1ggzH11kAhSB9NSCuHmKBwJGmtWkFhxlFQu1F4v1 cN0VG87yOP0XiXqVrUgW0yXrD7XH/XOtWwGdpEIfHkQrtnJbkYIcumzgJXqCCKhw2v v3bciVW/jAkFzTY2oLVN3qRnilCKzLfix2K6T9MI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411878AbgJUD4u (ORCPT ); Tue, 20 Oct 2020 23:56:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:55788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406735AbgJUD4u (ORCPT ); Tue, 20 Oct 2020 23:56:50 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F8B121741; Wed, 21 Oct 2020 03:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603252609; bh=XBGNkaYEUqlMFMVtbOPtDEIt72DqySZrBEAbtk/WssY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E8XjB3dAbYeiUgwvMORYBfO8EloEGDBXwEcgT9T0qXp0rkvzDtpREpia2yYO9/2mJ lxMjwxE/i6yzA6kfG1dHF48tWBJHivX8KNFDtgCT2i8k6uUrUUm21bYjRqFSszJ2No r1grpg3zlJ/XVbMGhIs4zob2RuajikrN0RpPR1Ts= Date: Tue, 20 Oct 2020 20:56:47 -0700 From: Jakub Kicinski To: Matthieu Baerts Cc: Geert Uytterhoeven , Mat Martineau , "David S . Miller" , Florian Westphal , Peter Krystad , netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it Message-ID: <20201020205647.20ab7009@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net> References: <20201020073839.29226-1-geert@linux-m68k.org> <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > On 20/10/2020 09:38, Geert Uytterhoeven wrote: > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may > > not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like > > is done for all other IPv6 features. > > Here again, the intension was to select IPv6 from MPTCP but I understand > the issue: if we enable MPTCP, we will select IPV6 as well by default. > Maybe not what we want on some embedded devices with very limited memory > where IPV6 is already off. We should instead enable MPTCP_IPV6 only if > IPV6=y. LGTM then! > > Reviewed-by: Matthieu Baerts Applied, thanks!