From: Jakub Kicinski <kuba@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Davide Caratti <dcaratti@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@resnulli.us>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Simon Horman <simon.horman@netronome.com>,
Shuang Li <shuali@redhat.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
Date: Tue, 20 Oct 2020 21:12:40 -0700 [thread overview]
Message-ID: <20201020211240.04d005e3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAM_iQpWk_x6j7Ox=u8Om=dnrKUwU7zDpDghW3LExQLf0+8pL6A@mail.gmail.com>
On Tue, 20 Oct 2020 17:33:22 -0700 Cong Wang wrote:
> On Tue, Oct 20, 2020 at 3:03 PM Davide Caratti <dcaratti@redhat.com> wrote:
> >
> > the following command
> >
> > # tc action add action tunnel_key \
> > > set src_ip 2001:db8::1 dst_ip 2001:db8::2 id 10 erspan_opts 1:6789:0:0
> >
> > generates the following splat:
> ...
> > using IPv6 tunnels, act_tunnel_key allocates a fixed amount of memory for
> > the tunnel metadata, but then it expects additional bytes to store tunnel
> > specific metadata with tunnel_key_copy_opts().
> >
> > Fix the arguments of __ipv6_tun_set_dst(), so that 'md_size' contains the
> > size previously computed by tunnel_key_get_opts_len(), like it's done for
> > IPv4 tunnels.
>
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied, thank you!
prev parent reply other threads:[~2020-10-21 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 22:02 [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels Davide Caratti
2020-10-21 0:33 ` Cong Wang
2020-10-21 4:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020211240.04d005e3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=shuali@redhat.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).