netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config
@ 2020-10-20 19:12 Robert Hancock
  2020-10-21  9:27 ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Hancock @ 2020-10-20 19:12 UTC (permalink / raw)
  To: linux, andrew, hkallweit1; +Cc: netdev, Robert Hancock

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper
operation in 1000BaseX mode. It should be safe to ensure this bit is
disabled in phylink_mii_c22_pcs_config in all cases.

Signed-off-by: Robert Hancock <robert.hancock@calian.com>
---
 drivers/net/phy/phylink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index fe2296fdda19..5d8c015bc9f2 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -2515,9 +2515,10 @@ int phylink_mii_c22_pcs_config(struct mdio_device *pcs, unsigned int mode,
 
 	changed = ret > 0;
 
+	/* Ensure ISOLATE bit is disabled */
 	bmcr = mode == MLO_AN_INBAND ? BMCR_ANENABLE : 0;
 	ret = mdiobus_modify(pcs->bus, pcs->addr, MII_BMCR,
-			     BMCR_ANENABLE, bmcr);
+			     BMCR_ANENABLE | BMCR_ISOLATE, bmcr);
 	if (ret < 0)
 		return ret;
 
-- 
2.18.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config
  2020-10-20 19:12 [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config Robert Hancock
@ 2020-10-21  9:27 ` Russell King - ARM Linux admin
  2020-10-21 17:37   ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2020-10-21  9:27 UTC (permalink / raw)
  To: Robert Hancock; +Cc: andrew, hkallweit1, netdev

On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote:
> The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper
> operation in 1000BaseX mode. It should be safe to ensure this bit is
> disabled in phylink_mii_c22_pcs_config in all cases.
> 
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>

Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>

Please re-send when netdev is open, thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config
  2020-10-21  9:27 ` Russell King - ARM Linux admin
@ 2020-10-21 17:37   ` Jakub Kicinski
  0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-10-21 17:37 UTC (permalink / raw)
  To: Russell King - ARM Linux admin; +Cc: Robert Hancock, andrew, hkallweit1, netdev

On Wed, 21 Oct 2020 10:27:36 +0100 Russell King - ARM Linux admin wrote:
> On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote:
> > The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper
> > operation in 1000BaseX mode. It should be safe to ensure this bit is
> > disabled in phylink_mii_c22_pcs_config in all cases.
> > 
> > Signed-off-by: Robert Hancock <robert.hancock@calian.com>  
> 
> Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Please re-send when netdev is open, thanks.

And please mark it as [PATCH net-next] when you resend next week -
just to be sure I don't get confused and apply this as a fix.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-21 17:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 19:12 [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config Robert Hancock
2020-10-21  9:27 ` Russell King - ARM Linux admin
2020-10-21 17:37   ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).