From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74498C56201 for ; Wed, 21 Oct 2020 09:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B71F821D6C for ; Wed, 21 Oct 2020 09:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="eey3Uumh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437029AbgJUJ1m (ORCPT ); Wed, 21 Oct 2020 05:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395379AbgJUJ1l (ORCPT ); Wed, 21 Oct 2020 05:27:41 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28901C0613CE for ; Wed, 21 Oct 2020 02:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mc6hifh/KkZK7uwL96aGQdsHmfHXRnV++EChIv1dZG4=; b=eey3UumhtOq3hiMivvt3xLRA2 +0ro+Yd6NA/UDCMq63EsaMaEKfjr33ceVgtBVGdDmHNa4kdYYO2jJjbf7x2jf8rfz5qeCoK6WQ64F 5ZqONidE/eYQUXt5vC/MjgwdRXxuBtlcRBHrLc/8hcGLw0gzGc9Rr72g9H9YSxglIZVMYDzHgekra ZaqI7Mj65EqngrLsJN7MJjYLxcpn1dvtTkdxfk1R7kQKdx3+Ye9mLMAtLQXWiRuknXq8/N4CiI17z c5kThUUklJwYcJwpBoj3Cpb32EMWpvDqy0Ebxs4Uau6/cZ839wBKKHPNlX7aGGf9Ji//BH/Y/TnkS 05L4kbV4Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49036) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVAPC-0000KB-0D; Wed, 21 Oct 2020 10:27:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVAPA-0006GX-R1; Wed, 21 Oct 2020 10:27:36 +0100 Date: Wed, 21 Oct 2020 10:27:36 +0100 From: Russell King - ARM Linux admin To: Robert Hancock Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config Message-ID: <20201021092736.GI1551@shell.armlinux.org.uk> References: <20201020191249.756832-1-robert.hancock@calian.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020191249.756832-1-robert.hancock@calian.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote: > The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper > operation in 1000BaseX mode. It should be safe to ensure this bit is > disabled in phylink_mii_c22_pcs_config in all cases. > > Signed-off-by: Robert Hancock Reviewed-by: Russell King Please re-send when netdev is open, thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!