From: Herbert Xu <herbert@gondor.apana.org.au>
To: "zhuoliang.zhang" <zhuoliang.zhang@mediatek.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH] net: xfrm: fix a race condition during allocing spi
Date: Thu, 22 Oct 2020 17:48:07 +1100 [thread overview]
Message-ID: <20201022064807.GA16043@gondor.apana.org.au> (raw)
In-Reply-To: <1603345995.13237.2.camel@mbjsdccf07>
On Thu, Oct 22, 2020 at 01:53:15PM +0800, zhuoliang.zhang wrote:
>
> there are 2 related hash lists : net->xfrm.state_bydst and
> net->xfrm.state_byspi:
>
> 1. a new state x is alloced in xfrm_state_alloc() and added into the
> bydst hlist in __find_acq_core() on the LHS;
> 2. on the RHS, state_hash_work thread travels the old bydst and tranfers
> every xfrm_state (include x) to the new bydst hlist and new byspi hlist;
> 3. user thread on the LHS gets the lock and adds x to the new byspi
> hlist again.
Good catch. Please add a Fixes header. I think this was introduced
with the dynamic resizing in f034b5d4efdfe0fb9e2a1ce1d95fa7914f24de49.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-10-22 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 8:18 [PATCH] net: xfrm: fix a race condition during allocing spi Zhuoliang Zhang
2020-10-21 7:12 ` Herbert Xu
[not found] ` <1603345995.13237.2.camel@mbjsdccf07>
2020-10-22 6:48 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022064807.GA16043@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=wsd_upstream@mediatek.com \
--cc=zhuoliang.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).