From: Rohit Maheshwari <rohitm@chelsio.com>
To: kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net
Cc: secdev@chelsio.com, Rohit Maheshwari <rohitm@chelsio.com>
Subject: [net 0/7] cxgb4/ch_ktls: Fixes in nic tls code
Date: Thu, 22 Oct 2020 15:40:12 +0530 [thread overview]
Message-ID: <20201022101019.7363-1-rohitm@chelsio.com> (raw)
This series helps in fixing multiple nic ktls issues.
Series is broken into 7 patches.
Patch 1 avoids deciding tls packet based on decrypted bit. If its
a retransmit packet which has tls handshake and finish (for
encryption), decrypted bit won't be set there, and so we can't
rely on decrypted bit.
Patch 2 helps supporting linear skb. SKBs were assumed non-linear.
Corrected the length extraction.
Patch 3 fixes kernel panic happening due to creating new skb for
each record. As part of fix driver will use same skb to send out
one tls record (partial data) of the same SKB.
Patch 4 avoids sending extra data which will be used to make a
record 16 byte aligned. We don't need to retransmit those extra
few bytes.
Patch 5 handles the cases where retransmit packet has tls starting
exchanges which are prior to tls start marker.
Patch 6 handles the small packet case which has partial TAG bytes
only. HW can't handle those, hence using sw crypto for such pkts.
Patch 7 corrects the potential tcb update problem.
Rohit Maheshwari (7):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding correct length
cxgb4/ch_ktls: creating skbs causes panic
ch_ktls: Correction in middle record handling
ch_ktls: packet handling prior to start marker
ch_ktls/cxgb4: handle partial tag alone SKBs
ch_ktls: tcb update fails sometimes
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 +
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 2 +
.../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 +
.../net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 8 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 111 ++-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 784 +++++++++---------
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1 +
7 files changed, 542 insertions(+), 370 deletions(-)
--
2.18.1
next reply other threads:[~2020-10-22 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 10:10 Rohit Maheshwari [this message]
2020-10-22 10:10 ` [net 1/7] cxgb4/ch_ktls: decrypted bit is not enough Rohit Maheshwari
2020-10-22 10:10 ` [net 2/7] ch_ktls: Correction in finding correct length Rohit Maheshwari
2020-10-22 10:10 ` [net 3/7] cxgb4/ch_ktls: creating skbs causes panic Rohit Maheshwari
2020-10-22 23:53 ` Jakub Kicinski
2020-10-22 10:10 ` [net 4/7] ch_ktls: Correction in middle record handling Rohit Maheshwari
2020-10-22 10:10 ` [net 5/7] ch_ktls: packet handling prior to start marker Rohit Maheshwari
2020-10-22 10:10 ` [net 6/7] ch_ktls/cxgb4: handle partial tag alone SKBs Rohit Maheshwari
2020-10-22 23:52 ` Jakub Kicinski
2020-10-22 10:10 ` [net 7/7] ch_ktls: tcb update fails sometimes Rohit Maheshwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022101019.7363-1-rohitm@chelsio.com \
--to=rohitm@chelsio.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).