From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEFFC388F9 for ; Thu, 22 Oct 2020 19:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D49EB21481 for ; Thu, 22 Oct 2020 19:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="WdHQm9X1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S370439AbgJVTwc (ORCPT ); Thu, 22 Oct 2020 15:52:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2509834AbgJVTwb (ORCPT ); Thu, 22 Oct 2020 15:52:31 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8CF1C0613CF for ; Thu, 22 Oct 2020 12:52:29 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id t4so1508644plq.13 for ; Thu, 22 Oct 2020 12:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3dm/6UU7gzYtewq70pBYmJhrFBt9p+uK9v/LY5XBQe8=; b=WdHQm9X1Ao2rROrM/DL9Ob5ETV5dcmcxbbi05C5ioxMtbjEFPu3amCoERC6BHS5ppC jUCpJ54iUYioZDSSbRWoRxCclHJU2JtZBbuzhQKlaoGfRi2P3C3aoYELYkdM3Ek82NIg /ql2TOC/FiXWF3ne/NQAZ463k3oht0RbEiVAsKFptqY+29o7VcNwnZHW3zobc8msa2X1 zO5gOJQMcdg6oEVFJShVA7kglwRFhbHPbFKzO/ozeQPE39n/MLVVx9kgdzBxWcAPTbDC +1ZEfeuMQ8ZS2WXFxUtATlwTjKv7PedQHfi0mdzi0cs+G6RgmmJ67hNItyrWmZIM4FVf /Txw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3dm/6UU7gzYtewq70pBYmJhrFBt9p+uK9v/LY5XBQe8=; b=rzCub75J4PAjT3cG4jbwBM7MivHubT5lJ80uh5SAPSIP8+GnNC6WHdrS3nUHux3ZMA K2p5QbJqPOyb6aVlLIhCEdo00Xpy+akNjCjOly5IxKiOssvfh4snWvap1y/ZW7DaNM7q zte6PvXwslgQUQ6S5dRU9z/f4+tZinyOxhm6dsAOc+xW9LKaVyye2G/UJc83jW5l8ynl dujjhcRY8NI/YBVPuRStn2BLmo3EAJH3In463RE6pKxn8pGFPO2P/MFyAXrWFUW6WNX1 zSdFAv1gXo5Xv1nsOuSi1pqRqQJtSC633Ky2x3S1kLswaiLZT81VJyMsaF71KBqJBqcb Mtgg== X-Gm-Message-State: AOAM532Pfi/0rfBIzguxLAh/qqv1PPsXSLx1m8m/Ank7oTprabKkALJL /HzA1CIrMqxqTr8xFbA6BCWqsw== X-Google-Smtp-Source: ABdhPJzjyClw+3ELYGBsJotUZeOWmDVypimCCUAzTRMpJKmazRpYQ3aDqmDvNYm9l9y12zeiB5Whew== X-Received: by 2002:a17:902:d697:b029:d6:48f:2974 with SMTP id v23-20020a170902d697b02900d6048f2974mr3724561ply.30.1603396349196; Thu, 22 Oct 2020 12:52:29 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b6sm2981568pjq.42.2020.10.22.12.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 12:52:28 -0700 (PDT) Date: Thu, 22 Oct 2020 12:52:20 -0700 From: Stephen Hemminger To: Vladimir Oltean Cc: David Ahern , Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" , Jakub Kicinski , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, jiri@mellanox.com, idosch@idosch.org Subject: Re: [RFC PATCH iproute2] bridge: add support for L2 multicast groups Message-ID: <20201022125220.45c24b30@hermes.local> In-Reply-To: <20201017184526.2333840-1-vladimir.oltean@nxp.com> References: <20201017184526.2333840-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 17 Oct 2020 21:45:26 +0300 Vladimir Oltean wrote: > Extend the 'bridge mdb' command for the following syntax: > bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent > > Signed-off-by: Vladimir Oltean > --- > bridge/mdb.c | 54 ++++++++++++++++++++++++++-------- > include/uapi/linux/if_bridge.h | 2 ++ > 2 files changed, 43 insertions(+), 13 deletions(-) > > diff --git a/bridge/mdb.c b/bridge/mdb.c > index 4cd7ca762b78..af160250928e 100644 > --- a/bridge/mdb.c > +++ b/bridge/mdb.c > @@ -149,6 +149,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e, > struct nlmsghdr *n, struct rtattr **tb) > { > const void *grp, *src; > + const char *addr; > SPRINT_BUF(abuf); > const char *dev; > int af; > @@ -156,9 +157,16 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e, > if (filter_vlan && e->vid != filter_vlan) > return; > > - af = e->addr.proto == htons(ETH_P_IP) ? AF_INET : AF_INET6; > - grp = af == AF_INET ? (const void *)&e->addr.u.ip4 : > - (const void *)&e->addr.u.ip6; > + if (!e->addr.proto) { > + af = AF_PACKET; > + grp = (const void *)&e->addr.u.mac_addr; > + } else if (e->addr.proto == htons(ETH_P_IP)) { > + af = AF_INET; > + grp = (const void *)&e->addr.u.ip4; > + } else { > + af = AF_INET6; > + grp = (const void *)&e->addr.u.ip6; > + } > dev = ll_index_to_name(ifindex); > In C casts of pointer to void are not necessary.