From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6636FC388F7 for ; Thu, 22 Oct 2020 23:05:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 089422245F for ; Thu, 22 Oct 2020 23:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603407956; bh=7B683fiZBdj0VRUX2fu8XxbR2rPaeo50RNyuPG3ILDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Q+RwcFwrothV+wClMdskQhd1jq7KZZX9CSGYL7hiuhhYeOlKcgzlvFv3FiKGed/OT /19WimeiMVyPcUeOZ4GAICy0J2y4RMu+/jJA6pPQTVVVRthXsw4BKCXFDabIE5FxSZ v0eXkP3zHVRrg9GAPaDpFENKSyp1zYH/nX7dty+M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S373216AbgJVXFz (ORCPT ); Thu, 22 Oct 2020 19:05:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S373210AbgJVXFy (ORCPT ); Thu, 22 Oct 2020 19:05:54 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7245223BF; Thu, 22 Oct 2020 23:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603407954; bh=7B683fiZBdj0VRUX2fu8XxbR2rPaeo50RNyuPG3ILDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lBRUyGGkMZVPoln+2s7NvyR8jgq0jTEu+OoYJ0k9jgIzZT6fuKGUfNKt0G0AiDde/ KT0oqsagXwIN2+TSLa6xrqDWeyIQuKGqDXnUgzm2guGg/G1BukDy89XK4Scmyf5XtW dOaOLdzJP2xe+rFuZMSexDBqkUlksCGciQsUetOM= Date: Thu, 22 Oct 2020 16:05:51 -0700 From: Jakub Kicinski To: Kees Cook Cc: Francis Laniel , linux-hardening@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy. Message-ID: <20201022160551.33d85912@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <202010221302.5BA047AC9@keescook> References: <20201020164707.30402-1-laniel_francis@privacyrequired.com> <20201020164707.30402-4-laniel_francis@privacyrequired.com> <202010211649.ABD53841B@keescook> <2286512.66XcFyAlgq@machine> <202010221302.5BA047AC9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 22 Oct 2020 13:04:32 -0700 Kees Cook wrote: > > > > From: Francis Laniel > > > > > > > > Calls to nla_strlcpy are now replaced by calls to nla_strscpy which is the > > > > new name of this function. > > > > > > > > Signed-off-by: Francis Laniel > > > > > > The Subject could also be: "treewide: Rename nla_strlcpy to nla_strscpy" > > > > > > But otherwise, yup, easy mechanical change. > > > > Should I submit a v4 for this change? > > I'll say yes. :) Drop the RFC, bump to v4, and send it to netdev (along > with all the other CCs you have here already), and add the Reviewed-bys > from v3. Maybe wait until next week, IIRC this doesn't fix any bugs, so it's -next material. We don't apply anything to net-next during the merge window.