From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=QbkO=D6=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A7216C4363A
	for <netdev@archiver.kernel.org>; Fri, 23 Oct 2020 18:23:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 46A822192A
	for <netdev@archiver.kernel.org>; Fri, 23 Oct 2020 18:23:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1603477387;
	bh=BDvsAL1BXlqK3Ru7FE0wBVk/qe9/Th/2RAp81DHYrMw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=myQPK0SxIDUKR4XHw9jx3ypVjoldZgMN4RExx1U6eWPyICjoLGjqdUITPFqQaRTud
	 GaFcfb0FGYbE/uuRuDLyaYDweERT1jhCFx3B5FJkw9v8+WlXrE+Wc9E6H7RlA4y7gw
	 eYS6uqIHKMUtslzup5Uf9fmmC8wh7V5QP/3ynaBI=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754636AbgJWSXG (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 23 Oct 2020 14:23:06 -0400
Received: from mail.kernel.org ([198.145.29.99]:52168 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S460555AbgJWSXG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 23 Oct 2020 14:23:06 -0400
Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 43194208FE;
        Fri, 23 Oct 2020 18:23:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1603477385;
        bh=BDvsAL1BXlqK3Ru7FE0wBVk/qe9/Th/2RAp81DHYrMw=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=bFN8xgxBAcOQKkTC9XcdhGiPiEykJ3sBQaZSceC6MfUIY0Exds/UcQkAlDwVLBH7H
         WqYdgWqPq3gQFYNGzK9lLdjNbfZAFNdc8CyttVdPUoRhWGWObNjleJxRLSvnP/55fl
         XjxTT1ySwLTZ+G8q2pov8UvDncNXidfF7B+0BhGI=
Date:   Fri, 23 Oct 2020 11:23:04 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Guillaume Nault <gnault@redhat.com>
Cc:     David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        Alexander Ovechkin <ovov@yandex-team.ru>,
        David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO
Message-ID: <20201023112304.086cd5e0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <5f5132fd657daa503c709b86c87ae147e28a78ad.1603469145.git.gnault@redhat.com>
References: <cover.1603469145.git.gnault@redhat.com>
        <5f5132fd657daa503c709b86c87ae147e28a78ad.1603469145.git.gnault@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 23 Oct 2020 18:19:43 +0200 Guillaume Nault wrote:
> Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"),
> mpls_iptunnel.ko has a softdep on mpls_gso.ko. For this to work, we
> need to ensure that mpls_gso.ko is built whenever MPLS_IPTUNNEL is set.

Does it generate an error or a warning? I don't know much about soft
dependencies, but I'd think it's optional.

> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
> index d672ab72ab12..b83093bcb48f 100644
> --- a/net/mpls/Kconfig
> +++ b/net/mpls/Kconfig
> @@ -33,6 +33,7 @@ config MPLS_ROUTING
>  config MPLS_IPTUNNEL
>  	tristate "MPLS: IP over MPLS tunnel support"
>  	depends on LWTUNNEL && MPLS_ROUTING
> +	select NET_MPLS_GSO
>  	help
>  	 mpls ip tunnel support.
>