From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5AEC388F7 for ; Sun, 25 Oct 2020 09:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F4E32225E for ; Sun, 25 Oct 2020 09:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603617780; bh=zyob1uJJFMg/3l5Ccy8tiIhLwAdla2K9dlocrrPKKiY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rJLB9Uyqko0iKprLdW+2b+UJdBcPtrArl8qazYpOlquICEAXXdHqy24+XNQfVau58 KkkvRi+YezFYBxBPfzLM/yjlfPNhcP8u8Wq9tiDgXoeGERjRkIJuICip5hY3xa6puB e8AzHw6WDep6gFB7o7wOLnbuJw/GeFr971bu2hzM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1414783AbgJYJW7 (ORCPT ); Sun, 25 Oct 2020 05:22:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1414778AbgJYJW7 (ORCPT ); Sun, 25 Oct 2020 05:22:59 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1F3622259; Sun, 25 Oct 2020 09:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603617778; bh=zyob1uJJFMg/3l5Ccy8tiIhLwAdla2K9dlocrrPKKiY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mDePK54IjYOE333bt19fKiguWbcXk7ad6uQrdwVP8DFnR1P87lUWSZzYTuP+1lHAi srQVcIJiUxkBBSYl7Uf6MlvPFfxtsQG3BtIQNNNxMXE8L+PXl9jhNDA9zPtvS/Rv3S JBNo/Ep57BqFX9PJJ+a74pqG2cQFfwEdSdO+AXog= Date: Sun, 25 Oct 2020 10:22:55 +0100 From: Greg Kroah-Hartman To: Alexander A Sverdlin Cc: devel@driverdev.osuosl.org, Aaro Koskinen , Ralf Baechle , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error Message-ID: <20201025092255.GA113243@kroah.com> References: <20201016101858.11374-1-alexander.sverdlin@nokia.com> <20201016101858.11374-2-alexander.sverdlin@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016101858.11374-2-alexander.sverdlin@nokia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit more readable. > > Signed-off-by: Alexander Sverdlin > Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") > > Change-Id: Ie1fadcc57cb5e221cf3e83c169b53a5533b8edff Please stop using gerrit for patches destined for upstream development :(