From: Andrew Lunn <andrew@lunn.ch>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Willy Liu <willy.liu@realtek.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH] net: phy: realtek: omit setting PHY-side delay when "rgmii" specified
Date: Sun, 25 Oct 2020 18:28:48 +0100 [thread overview]
Message-ID: <20201025172848.GI792004@lunn.ch> (raw)
In-Reply-To: <F5D81295-B4CD-4B80-846A-39503B70E765@aosc.io>
> >> 1. As the PHY chip has hardware configuration for configuring delays,
> >> we should at least have a mode that respects what's set on the
> >hardware.
> >
> >Yes, that is PHY_INTERFACE_MODE_NA. In DT, set the phy-mode to "". Or
> >for most MAC drivers, don't list a phy-mode at all.
>
> However, we still need to tell the MAC it's RGMII mode that is in use, not
> MII/RMII/*MII. So the phy-mode still needs to be something that
> contains rgmii.
So for this MAC driver, you are going to have to fix the device tree.
And for the short turn, maybe implement the workaround discussed in
the other thread.
Andrew
next prev parent reply other threads:[~2020-10-25 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 8:55 [PATCH] net: phy: realtek: omit setting PHY-side delay when "rgmii" specified Icenowy Zheng
2020-10-25 14:18 ` Andrew Lunn
2020-10-25 14:27 ` [linux-sunxi] " Icenowy Zheng
2020-10-25 14:36 ` Andrew Lunn
2020-10-25 16:51 ` Icenowy Zheng
2020-10-25 17:28 ` Andrew Lunn [this message]
2020-10-26 7:44 ` Icenowy Zheng
2020-10-26 12:12 ` Andrew Lunn
2020-10-28 2:46 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025172848.GI792004@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=kuba@kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).