From: Jakub Kicinski <kuba@kernel.org>
To: Masahiro Fujiwara <fujiwara.masahiro@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Harald Welte <laforge@gnumonks.org>,
"David S. Miller" <davem@davemloft.net>,
Andreas Schultz <aschultz@tpip.net>,
osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] gtp: fix an use-before-init in gtp_newlink()
Date: Mon, 26 Oct 2020 11:46:33 -0700 [thread overview]
Message-ID: <20201026114633.1b2628ae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201026072227.7280-1-fujiwara.masahiro@gmail.com>
On Mon, 26 Oct 2020 16:22:27 +0900 Masahiro Fujiwara wrote:
> v2:
> - leave out_hashtable: label for clarity (Jakub).
> - fix code and comment styles.
Thanks!
> diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
> index 8e47d0112e5d..07cb6d9495e8 100644
> --- a/drivers/net/gtp.c
> +++ b/drivers/net/gtp.c
> @@ -663,10 +663,6 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev,
>
> gtp = netdev_priv(dev);
>
> - err = gtp_encap_enable(gtp, data);
> - if (err < 0)
> - return err;
> -
> if (!data[IFLA_GTP_PDP_HASHSIZE]) {
> hashsize = 1024;
> } else {
> @@ -676,13 +672,17 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev,
> }
>
> err = gtp_hashtable_new(gtp, hashsize);
> + if (err < 0)
> + return err;
> +
> + err = gtp_encap_enable(gtp, data);
> if (err < 0)
> goto out_encap;
This needs to say goto out_hashtable; now.
next prev parent reply other threads:[~2020-10-26 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 15:42 [PATCH net] gtp: fix an use-before-init in gtp_newlink() Masahiro Fujiwara
2020-10-25 21:05 ` Jakub Kicinski
2020-10-26 6:37 ` Masahiro Fujiwara
2020-10-26 7:22 ` [PATCH v2 " Masahiro Fujiwara
2020-10-26 18:46 ` Jakub Kicinski [this message]
2020-10-27 11:30 ` [PATCH v3] " Masahiro Fujiwara
2020-10-27 11:48 ` [PATCH v3 net] " Masahiro Fujiwara
2020-10-29 16:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026114633.1b2628ae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=aschultz@tpip.net \
--cc=davem@davemloft.net \
--cc=fujiwara.masahiro@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).