From: Aleksandr Nogikh <aleksandrnogikh@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, johannes@sipsolutions.net
Cc: edumazet@google.com, andreyknvl@google.com, dvyukov@google.com,
elver@google.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
willemdebruijn.kernel@gmail.com,
Aleksandr Nogikh <nogikh@google.com>
Subject: [PATCH v3 3/3] mac80211: add KCOV remote annotations to incoming frame processing
Date: Mon, 26 Oct 2020 15:08:51 +0000 [thread overview]
Message-ID: <20201026150851.528148-4-aleksandrnogikh@gmail.com> (raw)
In-Reply-To: <20201026150851.528148-1-aleksandrnogikh@gmail.com>
From: Aleksandr Nogikh <nogikh@google.com>
Add KCOV remote annotations to ieee80211_iface_work and
ieee80211_rx. This will enable coverage-guided fuzzing of
mac80211 code that processes incoming 802.11 frames.
Signed-off-by: Aleksandr Nogikh <nogikh@google.com>
---
v1 -> v2:
* The commit now affects ieee80211_rx instead of
ieee80211_tasklet_handler.
---
include/net/mac80211.h | 2 ++
net/mac80211/iface.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index e8e295dae744..f4c37a1b381e 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -4499,7 +4499,9 @@ void ieee80211_rx_napi(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
*/
static inline void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb)
{
+ kcov_remote_start_common(skb_get_kcov_handle(skb));
ieee80211_rx_napi(hw, NULL, skb, NULL);
+ kcov_remote_stop();
}
/**
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 1be775979132..56a1bcea2c1c 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1356,6 +1356,7 @@ static void ieee80211_iface_work(struct work_struct *work)
while ((skb = skb_dequeue(&sdata->skb_queue))) {
struct ieee80211_mgmt *mgmt = (void *)skb->data;
+ kcov_remote_start_common(skb_get_kcov_handle(skb));
if (ieee80211_is_action(mgmt->frame_control) &&
mgmt->u.action.category == WLAN_CATEGORY_BACK) {
int len = skb->len;
@@ -1465,6 +1466,7 @@ static void ieee80211_iface_work(struct work_struct *work)
}
kfree_skb(skb);
+ kcov_remote_stop();
}
/* then other type-dependent work */
--
2.29.0.rc1.297.gfa9743e501-goog
prev parent reply other threads:[~2020-10-26 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 15:08 [PATCH v3 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Aleksandr Nogikh
2020-10-26 15:08 ` [PATCH v3 1/3] kernel: make kcov_common_handle consider the current context Aleksandr Nogikh
2020-10-26 15:08 ` [PATCH v3 2/3] net: add kcov handle to skb extensions Aleksandr Nogikh
2020-10-26 16:56 ` Willem de Bruijn
2020-10-27 12:31 ` Aleksandr Nogikh
2020-10-27 13:13 ` Willem de Bruijn
2020-10-26 17:34 ` kernel test robot
2020-10-26 18:55 ` kernel test robot
2020-10-26 15:08 ` Aleksandr Nogikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026150851.528148-4-aleksandrnogikh@gmail.com \
--to=aleksandrnogikh@gmail.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).