From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBA3C388F9 for ; Tue, 27 Oct 2020 11:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31C44222D9 for ; Tue, 27 Oct 2020 11:30:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pFRPSL+G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750027AbgJ0Lao (ORCPT ); Tue, 27 Oct 2020 07:30:44 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:55564 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750001AbgJ0Lae (ORCPT ); Tue, 27 Oct 2020 07:30:34 -0400 Received: by mail-pj1-f65.google.com with SMTP id c17so618616pjo.5; Tue, 27 Oct 2020 04:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mgmaXaSSxDiV1b+vN33kB7/M7evqK+m/IRdQHJNh9jk=; b=pFRPSL+GSCzBQDKauwbGT6fQCTggPxcs6myOc39+QrHiAEc6OuJx36gjiOuDt6wAmc oLgBdbCAMFPK315jRpNz5EpcvNVfgX1MBVloYI1s1Pdr51JyqVRQx9ee1F94TNlYb8Bx ErXcZ1iUTwVyFIas59jyygcX+hXBjHq07yvxpnkB9drXLXIOUG1YEjHe2Yng5c32szOE gThDTkEcGAenGz4hq7uC3LREMabLk1fUJYMk5i/ceAUNlUsv5hoeXbk2Rc1S+0YSSvek zEU11/PBq4nJtK6D2qlrSPF8DzvMNKDAt7NEYvGfVKjqncdUSIuh91klphYhGj0nsdt4 iVBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mgmaXaSSxDiV1b+vN33kB7/M7evqK+m/IRdQHJNh9jk=; b=VJhVIDQAxNRx8Fgg0Qkb5J7fkv14aPDxYrsIzFKCqouFR4Tv5ama5KHZ4C45m4OpTw LLh2DqmzoSOghDXTpTp6oUiZYl6JW1OmgvyVg5oGVUrN/I0XJd3vk1qULW5pE+E6Gpcw +DpelvoY7hPrtsnDPXB1Lyf69zc9W8E9GRp26/IuGo3wMmQfpZyVnCkGG+s7PRBaRqtz xuGgSoXDJdwQyJ3RX40h5zeiokXX+2g/l9y7s+JV0NQTuOcH/Xa3XwZIxCfsjNFEs2eq 6kKYTFW1pa+/nkg4dsPk8qktXS29CiLxFiPNzllAAed7Z6Na4GGsDxUtxIx5GVZsg313 GOKw== X-Gm-Message-State: AOAM531vgRpEQiryKfJJj4NsvRN1t0EnoCQgPLsD77stss/TCwz/+4A8 3CZizK5XpzaCyy1czgNtQuQ= X-Google-Smtp-Source: ABdhPJwsqWSwXmygTrmntcqynMZDWqdNru0B16qHE/XYS3+TXU2exIp7TDeoTYcfbjfH8CjS6AuBQA== X-Received: by 2002:a17:902:7046:b029:d5:a5e3:4701 with SMTP id h6-20020a1709027046b02900d5a5e34701mr1819449plt.57.1603798233456; Tue, 27 Oct 2020 04:30:33 -0700 (PDT) Received: from lte-devbox.localdomain (KD106154081201.au-net.ne.jp. [106.154.81.201]) by smtp.googlemail.com with ESMTPSA id v1sm1536951pjt.2.2020.10.27.04.30.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 04:30:32 -0700 (PDT) From: Masahiro Fujiwara To: Pablo Neira Ayuso , Harald Welte Cc: fujiwara.masahiro@gmail.com, "David S. Miller" , Jakub Kicinski , Andreas Schultz , osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] gtp: fix an use-before-init in gtp_newlink() Date: Tue, 27 Oct 2020 20:30:21 +0900 Message-Id: <20201027113021.3581-1-fujiwara.masahiro@gmail.com> X-Mailer: git-send-email 2.24.3 In-Reply-To: <20201026114633.1b2628ae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> References: <20201026114633.1b2628ae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org *_pdp_find() from gtp_encap_recv() would trigger a crash when a peer sends GTP packets while creating new GTP device. RIP: 0010:gtp1_pdp_find.isra.0+0x68/0x90 [gtp] Call Trace: gtp_encap_recv+0xc2/0x2e0 [gtp] ? gtp1_pdp_find.isra.0+0x90/0x90 [gtp] udp_queue_rcv_one_skb+0x1fe/0x530 udp_queue_rcv_skb+0x40/0x1b0 udp_unicast_rcv_skb.isra.0+0x78/0x90 __udp4_lib_rcv+0x5af/0xc70 udp_rcv+0x1a/0x20 ip_protocol_deliver_rcu+0xc5/0x1b0 ip_local_deliver_finish+0x48/0x50 ip_local_deliver+0xe5/0xf0 ? ip_protocol_deliver_rcu+0x1b0/0x1b0 gtp_encap_enable() should be called after gtp_hastable_new() otherwise *_pdp_find() will access the uninitialized hash table. v2: - Leave out_hashtable: label for clarity (Jakub). - Fix code and comment styles. Fixes: 1e3a3abd8b28 ("gtp: make GTP sockets in gtp_newlink optional") Signed-off-by: Masahiro Fujiwara --- v3: - Fix goto err label. drivers/net/gtp.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 8e47d0112e5d..10f910f8cbe5 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -663,10 +663,6 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev, gtp = netdev_priv(dev); - err = gtp_encap_enable(gtp, data); - if (err < 0) - return err; - if (!data[IFLA_GTP_PDP_HASHSIZE]) { hashsize = 1024; } else { @@ -677,12 +673,16 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev, err = gtp_hashtable_new(gtp, hashsize); if (err < 0) - goto out_encap; + return err; + + err = gtp_encap_enable(gtp, data); + if (err < 0) + goto out_hashtable; err = register_netdevice(dev); if (err < 0) { netdev_dbg(dev, "failed to register new netdev %d\n", err); - goto out_hashtable; + goto out_encap; } gn = net_generic(dev_net(dev), gtp_net_id); @@ -693,11 +693,11 @@ static int gtp_newlink(struct net *src_net, struct net_device *dev, return 0; +out_encap: + gtp_encap_disable(gtp); out_hashtable: kfree(gtp->addr_hash); kfree(gtp->tid_hash); -out_encap: - gtp_encap_disable(gtp); return err; } -- 2.24.3