From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18E9C55179 for ; Wed, 28 Oct 2020 01:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B113622258 for ; Wed, 28 Oct 2020 01:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603849679; bh=DPgj3zYuKLPjEZ/p/duM7uAOzRSW2Xntsna187+y55k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=AWp/hzeOA28uETOF4HtMOvsyESa16sKtm03mOP3mdfnJkHb2GfMxMMtTbP+vvJPZd OqVoTHuqe5xSnIuwU0uzZBR+gfbDThZEU/lLE8ijhZyScbJKDKxKhTDr98AOpjWU+X MlgT2RGNl7jQl+bpKTgqxGtRDS96vB+PNFXJkqQs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726057AbgJ1Bia (ORCPT ); Tue, 27 Oct 2020 21:38:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:35080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1833064AbgJ0X4Q (ORCPT ); Tue, 27 Oct 2020 19:56:16 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C906207D8; Tue, 27 Oct 2020 23:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603842975; bh=DPgj3zYuKLPjEZ/p/duM7uAOzRSW2Xntsna187+y55k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JpIX27w7Q+vj3Oewxu6i08uysquDDK/6OpC7aFBEEKfzKxLCCakd0347BvTZe5oj4 p2R2K6p1PjzvDqPxpOSfzIaXaiQM+OSGNi6Zi6UsvLbpVD0/qKxd9WHOURxyqACZLY ldBsxdmKEHsMjxcY4gwSLtMyIn/ppnLkyqAG6YoI= Date: Tue, 27 Oct 2020 16:56:14 -0700 From: Jakub Kicinski To: Vinay Kumar Yadav Cc: netdev@vger.kernel.org, davem@davemloft.net, secdev@chelsio.com Subject: Re: [PATCH net] chelsio/chtls: fix memory leaks in CPL handlers Message-ID: <20201027165614.564d0941@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201025194228.31271-1-vinay.yadav@chelsio.com> References: <20201025194228.31271-1-vinay.yadav@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 26 Oct 2020 01:12:29 +0530 Vinay Kumar Yadav wrote: > CPL handler functions chtls_pass_open_rpl() and > chtls_close_listsrv_rpl() should return CPL_RET_BUF_DONE > so that caller function will do skb free to avoid leak. > > Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") > Signed-off-by: Vinay Kumar Yadav Applied.