From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680DEC55179 for ; Thu, 29 Oct 2020 00:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A4D720790 for ; Thu, 29 Oct 2020 00:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603931717; bh=ceOVLv+DLKtAkAr/A90oUkAov3JpX2pYzKeRxT/m8ko=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MzE2XQs6dBW5WurosoFKuuN4Bl8bl/Xulh30n19O+KSQwD0CrZB5adwZmyafaT4pY Y0skjfWrHJxGip0rlW7Td7zT266HCL0vWI146JVqNWRlhHgsDL0BBs6pODsok4ZHbc /vJq3oICVRU4EBB2+t+V2yoCvqjmflF6OZcb9Hkw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731920AbgJ1WT1 (ORCPT ); Wed, 28 Oct 2020 18:19:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:60516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731765AbgJ1WRo (ORCPT ); Wed, 28 Oct 2020 18:17:44 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C1742075E; Wed, 28 Oct 2020 00:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603845747; bh=ceOVLv+DLKtAkAr/A90oUkAov3JpX2pYzKeRxT/m8ko=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eTPpMYvG2llfrQYxCmb/givA+OlquuQWJp0/I8MOYuR5QgyH29Yk7EDoc9WibUkt8 +bqV5Ppeu/oiCewNoJi+kf1hk3THnnly14/SBegOfx00qmwf4391slgvhCRuDb/9IZ kSD9/w3cyaIJl+GFCk8qUdgbMIGqvQ3TiLbeLJ28= Date: Tue, 27 Oct 2020 17:42:26 -0700 From: Jakub Kicinski To: Arnd Bergmann Cc: Chas Williams <3chas3@gmail.com>, Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , "David S. Miller" , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning Message-ID: <20201027174226.4bd50144@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201026213040.3889546-1-arnd@kernel.org> References: <20201026213040.3889546-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 26 Oct 2020 22:29:48 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Building a "W=1" kernel with clang produces a warning about > suspicous pointer arithmetic: > > drivers/atm/horizon.c:1844:52: warning: performing pointer arithmetic > on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > for (mem = (HDW *) memmap; mem < (HDW *) (memmap + 1); ++mem) > > The way that the addresses are handled is very obscure, and > rewriting it to be more conventional seems fairly pointless, given > that this driver probably has no users. > Shut up this warning by adding a cast to uintptr_t. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Arnd Bergmann Hi! I'm not sure what your plan is for re-spinning but when you do could you please split the wireless changes out? Also we never got patch 3 IDK if that's a coincidence or if it wasn't for networking...