From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A77C56202 for ; Thu, 29 Oct 2020 00:55:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8843620724 for ; Thu, 29 Oct 2020 00:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603932955; bh=j9PkiQ7S1inYkjVg1VlbFXYGya4JPZOEejPm0DCw75c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=n5T5bf0T5Kh/KzGhHFM94D/3N5scjz2oXS5p3xskBR09ClKTD9J574k3/69sdVJYA VE7MszSJRTZelWTzmKALRF8NGsLvwnRpGHosfMQTeVR8O1mLEIm8Wu+JRpbZRbMdFe 9Rn9RaeRkfkjVYuNKzAf9x1KAZKYePkvBkg6q854= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390961AbgJ2Azz (ORCPT ); Wed, 28 Oct 2020 20:55:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:60524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731653AbgJ1WRk (ORCPT ); Wed, 28 Oct 2020 18:17:40 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0531822249; Wed, 28 Oct 2020 05:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603862940; bh=j9PkiQ7S1inYkjVg1VlbFXYGya4JPZOEejPm0DCw75c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KKnF7PIFtiOmh/Du1pR4PL9WEBX9ONCmXSKMZg2cQ0MMW5IPBn73oeTnd2N2au7hi 6TIwPyp/z8M5Pt8R1r9alQwBwLiIzcDYxQ3vtbJNqdPFEuCbIrhHTDV5ENcqtPYOXb +Uc7jPRh5nvf82242EeQ8oIl4/uZ6IgriALUCn6w= Date: Wed, 28 Oct 2020 07:28:56 +0200 From: Leon Romanovsky To: Jakub Kicinski Cc: "David S . Miller" , Cong Wang , Jamal Hadi Salim , Jiri Pirko , netdev@vger.kernel.org, Pablo Neira Ayuso , Vlad Buslov Subject: Re: [PATCH net v1] net: protect tcf_block_unbind with block lock Message-ID: <20201028052856.GF1763578@unreal> References: <20201026123327.1141066-1-leon@kernel.org> <20201027180331.42ece60f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027180331.42ece60f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 27, 2020 at 06:03:31PM -0700, Jakub Kicinski wrote: > On Mon, 26 Oct 2020 14:33:27 +0200 Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The tcf_block_unbind() expects that the caller will take block->cb_lock > > before calling it, however the code took RTNL lock and dropped cb_lock > > instead. This causes to the following kernel panic. > > > Fixes: 0fdcf78d5973 ("net: use flow_indr_dev_setup_offload()") > > Signed-off-by: Leon Romanovsky > > --- > > v1: > > * Returned rtnl_lock() > > v0: > > https://lore.kernel.org/netdev/20201026060407.583080-1-leon@kernel.org > > Applied, thanks. > > I'm surprised you put the lore link in the notes. Maybe the usefulness > of the change log could be argued, but the number of times I tried to > find a specific revision and couldn't... This is my preferred way of submitting patches, it allows to enjoy from all worlds: clean commit message and ability to see previous versions at the same time. Lorifier [1] gives such links to me in automatic way, all that I need is to copy them from previous versions. [1] https://github.com/danrue/lorifier Thanks