From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B275BC55179 for ; Thu, 29 Oct 2020 00:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F7A920780 for ; Thu, 29 Oct 2020 00:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390790AbgJ2AN0 (ORCPT ); Wed, 28 Oct 2020 20:13:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50742 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731745AbgJ2ANX (ORCPT ); Wed, 28 Oct 2020 20:13:23 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXkAR-003y9L-A8; Wed, 28 Oct 2020 13:03:03 +0100 Date: Wed, 28 Oct 2020 13:03:03 +0100 From: Andrew Lunn To: Pavana Sharma Cc: f.fainelli@gmail.com, davem@davemloft.net, gregkh@linuxfoundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com Subject: Re: [PATCH v5 1/3] net: phy: Add 5GBASER interface mode Message-ID: <20201028120303.GA933237@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 28, 2020 at 10:08:27AM +1000, Pavana Sharma wrote: > Add new mode supported by MV88E6393 family. > > Signed-off-by: Pavana Sharma > --- > include/linux/phy.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 3a09d2bf69ea..9de7c57cfd38 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -107,6 +107,7 @@ typedef enum { > PHY_INTERFACE_MODE_2500BASEX, > PHY_INTERFACE_MODE_RXAUI, > PHY_INTERFACE_MODE_XAUI, > + PHY_INTERFACE_MODE_5GBASER, > /* 10GBASE-R, XFI, SFI - single lane 10G Serdes */ > PHY_INTERFACE_MODE_10GBASER, > PHY_INTERFACE_MODE_USXGMII, Hi Pavana You need to add this new mode to the kerneldoc above the typedef. Otherwise you will get a warning from W=1 and kernel documentation build process. Andrew