From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Sumit Garg" <sumit.garg@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Steve McIntyre" <steve@einval.com>,
"open list:BPF JIT for MIPS (32-BIT AND 64-BIT)"
<netdev@vger.kernel.org>, "Willy Liu" <willy.liu@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Sasha Levin" <sashal@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Masahisa Kojima" <masahisa.kojima@linaro.org>
Subject: Re: realtek PHY commit bbc4d71d63549 causes regression
Date: Thu, 29 Oct 2020 16:46:44 +0200 [thread overview]
Message-ID: <20201029144644.GA70799@apalos.home> (raw)
In-Reply-To: <20201029143934.GO878328@lunn.ch>
On Thu, Oct 29, 2020 at 03:39:34PM +0100, Andrew Lunn wrote:
> > What about reverting the realtek PHY commit from stable?
> > As Ard said it doesn't really fix anything (usage wise) and causes a bunch of
> > problems.
> >
> > If I understand correctly we have 3 options:
> > 1. 'Hack' the drivers in stable to fix it (and most of those hacks will take
> > a long time to remove)
> > 2. Update DTE of all affected devices, backport it to stable and force users to
> > update
> > 3. Revert the PHY commit
> >
> > imho [3] is the least painful solution.
>
> The PHY commit is correct, in that it fixes a bug. So i don't want to
> remove it.
Yea I meant revert the commit from were ever it was backported, not on current
upstream. I agree it's correct from a coding point of view, but it never
actually fixes anything functionality wise of the affected platforms.
On the contrary, it breaks platforms without warning.
>
> Backporting it to stable is what is causing most of the issues today,
> combined with a number of broken DT descriptions. So i would be happy
> for stable to get a patch which looks at the strapping, sees ID is
> enabled via strapping, warns the DT blob is FUBAR, and then ignores
> the requested PHY-mode. That gives developers time to fix their broken
> DT.
(Ard replied on this while I was typing)
>
> Andrew
Cheers
/Ilias
next prev parent reply other threads:[~2020-10-29 14:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 14:20 realtek PHY commit bbc4d71d63549 causes regression Ard Biesheuvel
2020-10-17 14:44 ` Andrew Lunn
2020-10-17 14:46 ` Ard Biesheuvel
2020-10-17 15:11 ` Andrew Lunn
2020-10-17 15:18 ` Ard Biesheuvel
2020-10-17 16:14 ` Ilias Apalodimas
2020-10-17 16:17 ` Ard Biesheuvel
2020-10-17 16:21 ` Ilias Apalodimas
2020-10-17 18:04 ` Andrew Lunn
2020-10-17 18:11 ` Ard Biesheuvel
2020-10-17 18:17 ` Ard Biesheuvel
2020-10-17 18:27 ` Andrew Lunn
2020-10-17 18:55 ` Ard Biesheuvel
2020-10-17 19:49 ` Andrew Lunn
2020-10-17 22:19 ` Ard Biesheuvel
2020-10-17 23:02 ` Andrew Lunn
2020-10-18 10:35 ` Ard Biesheuvel
2020-10-18 10:56 ` Ard Biesheuvel
2020-10-18 15:45 ` Andrew Lunn
2020-10-25 14:16 ` Ard Biesheuvel
2020-10-25 14:28 ` Andrew Lunn
2020-10-25 14:34 ` Ard Biesheuvel
2020-10-25 14:42 ` Andrew Lunn
2020-10-29 14:21 ` Ilias Apalodimas
2020-10-29 14:39 ` Andrew Lunn
2020-10-29 14:42 ` Ard Biesheuvel
2020-10-29 14:50 ` Andrew Lunn
2020-10-29 14:46 ` Ilias Apalodimas [this message]
2020-11-05 17:31 ` Jernej Škrabec
2020-11-13 13:50 ` Arnd Bergmann
2020-11-13 14:44 ` Andrew Lunn
2020-11-13 15:33 ` Arnd Bergmann
2020-11-13 16:56 ` Andrew Lunn
2020-11-13 21:26 ` Arnd Bergmann
2020-11-13 22:43 ` Andrew Lunn
2020-11-13 22:49 ` Ard Biesheuvel
2020-11-14 0:40 ` Andrew Lunn
2020-11-14 10:09 ` Ard Biesheuvel
2020-10-18 15:38 ` Andrew Lunn
2020-10-18 14:20 ` Masami Hiramatsu
2020-10-17 18:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029144644.GA70799@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=andrew@lunn.ch \
--cc=ardb@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=steve@einval.com \
--cc=sumit.garg@linaro.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).