From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19B3C4742C for ; Fri, 30 Oct 2020 23:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B8DD20A8B for ; Fri, 30 Oct 2020 23:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604101570; bh=ZfF4RTtFvziN1B/oL/EJPYQE9v7+IqqByCucjDK5Mwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=SWjAV/HzG37rwcGNt1bFT1MascAC/HZR8V5uLWk30CwAQMTL25jI3+7wwFIFLF28e H1jZgtNcEG9oOR+YyYXXne5H+OA9q7JXrKcj2Dw4RpzmxnrPgJqD7ABb2ru8/ceIMv rYbi7b+NsJ09V+c6G2UvsQ2xjQQr1FoCT2vdLh+I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725857AbgJ3XqJ (ORCPT ); Fri, 30 Oct 2020 19:46:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:50060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJ3XqJ (ORCPT ); Fri, 30 Oct 2020 19:46:09 -0400 Received: from localhost (otava-0257.koleje.cuni.cz [78.128.181.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1388C208B6; Fri, 30 Oct 2020 23:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604101569; bh=ZfF4RTtFvziN1B/oL/EJPYQE9v7+IqqByCucjDK5Mwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Aw6BqvbF8qTCx4t2/v92dqtd/Fz9gsGVCD0bo4nRqtK/VnIAVismWlLDHnseLrVPT GMUEbG+7da2H+82H+x3JwiAJdF1WkIq4ZiqDyp6kIgUih6q3GjRRANJBZYOVWGad9z E1U5YxvsnzYSurwDpznQ0n4qVKbbbgX6YPUstUTQ= Date: Sat, 31 Oct 2020 00:45:56 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Jacek Anaszewski Cc: netdev@vger.kernel.org, linux-leds@vger.kernel.org, Pavel Machek , Dan Murphy , Russell King , Andrew Lunn , Matthias Schiffer , "David S. Miller" , Ben Whitten Subject: Re: [PATCH RFC leds + net-next 2/7] leds: trigger: netdev: simplify the driver by using bit field members Message-ID: <20201031004556.32c61a9d@kernel.org> In-Reply-To: <64419e33-ffcd-4082-01bd-3370dae86b4b@gmail.com> References: <20201030114435.20169-1-kabel@kernel.org> <20201030114435.20169-3-kabel@kernel.org> <64419e33-ffcd-4082-01bd-3370dae86b4b@gmail.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 30 Oct 2020 23:37:52 +0100 Jacek Anaszewski wrote: > Hi Marek, > > Bitops are guaranteed to be atomic and this was done for a reason. Hmm okay... Sooo, netdev_trig_work cannot be executed at the same time as the link/linkup/rx/tx changing stuff from netdev_trig_notify, interval_store or netdev_led_attr_store, because all these functions ensure cancelation of netdev_trig_work by calling cancel_delayed_work_sync. Doesn't this somehow prevent the need for memory barriers provided by atomic bitops? BTW Jacek what do you think about the other patches? Marek