From: Jakub Kicinski <kuba@kernel.org>
To: Aleksandr Nogikh <aleksandrnogikh@gmail.com>
Cc: davem@davemloft.net, johannes@sipsolutions.net,
edumazet@google.com, andreyknvl@google.com, dvyukov@google.com,
elver@google.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
willemdebruijn.kernel@gmail.com,
Aleksandr Nogikh <nogikh@google.com>
Subject: Re: [PATCH v5 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling
Date: Mon, 2 Nov 2020 19:00:35 -0800 [thread overview]
Message-ID: <20201102190035.2c1c65ce@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201029173620.2121359-1-aleksandrnogikh@gmail.com>
On Thu, 29 Oct 2020 17:36:17 +0000 Aleksandr Nogikh wrote:
> From: Aleksandr Nogikh <nogikh@google.com>
>
> This patch series enables remote KCOV coverage collection during
> 802.11 frames processing. These changes make it possible to perform
> coverage-guided fuzzing in search of remotely triggerable bugs.
>
> Normally, KCOV collects coverage information for the code that is
> executed inside the system call context. It is easy to identify where
> that coverage should go and whether it should be collected at all by
> looking at the current process. If KCOV was enabled on that process,
> coverage will be stored in a buffer specific to that process.
> Howerever, it is not always enough as handling can happen elsewhere
> (e.g. in separate kernel threads).
>
> When it is impossible to infer KCOV-related info just by looking at
> the currently running process, one needs to manually pass some
> information to the code that should be instrumented. The information
> takes the form of 64 bit integers (KCOV remote handles). Zero is the
> special value that corresponds to an empty handle. More details on
> KCOV and remote coverage collection can be found in
> Documentation/dev-tools/kcov.rst.
>
> The series consists of three commits.
> 1. Apply a minor fix to kcov_common_handle() so that it returns a
> valid handle (zero) when called in an interrupt context.
> 2. Take the remote handle from KCOV and attach it to newly allocated
> SKBs as an skb extension. If the allocation happens inside a system
> call context, the SKB will be tied to the process that issued the
> syscall (if that process is interested in remote coverage collection).
> 3. Annotate the code that processes incoming 802.11 frames with
> kcov_remote_start()/kcov_remote_stop().
Applied, thanks.
prev parent reply other threads:[~2020-11-03 3:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 17:36 [PATCH v5 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Aleksandr Nogikh
2020-10-29 17:36 ` [PATCH v5 1/3] kernel: make kcov_common_handle consider the current context Aleksandr Nogikh
2020-10-29 17:36 ` [PATCH v5 2/3] net: add kcov handle to skb extensions Aleksandr Nogikh
2020-11-21 16:09 ` Ido Schimmel
2020-11-21 16:52 ` Florian Westphal
2020-11-21 17:39 ` Johannes Berg
2020-11-21 18:06 ` Jakub Kicinski
2020-11-21 18:12 ` Johannes Berg
2020-11-21 18:35 ` Jakub Kicinski
2020-11-21 19:30 ` Johannes Berg
2020-11-21 20:55 ` Jakub Kicinski
2020-11-21 20:58 ` Johannes Berg
2020-11-21 21:02 ` Jakub Kicinski
2020-11-25 16:30 ` Marco Elver
2020-12-01 1:52 ` Jakub Kicinski
2020-12-01 7:35 ` Ido Schimmel
2020-12-01 16:43 ` Jakub Kicinski
2020-10-29 17:36 ` [PATCH v5 3/3] mac80211: add KCOV remote annotations to incoming frame processing Aleksandr Nogikh
2020-10-29 17:44 ` Johannes Berg
2020-10-29 18:00 ` Marco Elver
2020-10-29 19:08 ` Andrey Konovalov
2020-11-03 3:00 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102190035.2c1c65ce@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=aleksandrnogikh@gmail.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).