From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA676C2D0A3 for ; Tue, 3 Nov 2020 17:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78F89206F8 for ; Tue, 3 Nov 2020 17:30:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AlCP2CRz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbgKCRaL (ORCPT ); Tue, 3 Nov 2020 12:30:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbgKCRaK (ORCPT ); Tue, 3 Nov 2020 12:30:10 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E82C0613D1 for ; Tue, 3 Nov 2020 09:30:09 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id k3so25311677ejj.10 for ; Tue, 03 Nov 2020 09:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WCLr1NcOcb3nGONEyUolkVCU02HBtDkANd61Ptf8MKg=; b=AlCP2CRzU/5D4BuA682nevGOv3ydL5HSVD/EgiFQnf7W/JOOGTpLYlm/boxkStHtwx abRldHrrzWy2Q6hl0uHuPZvZej79zMkxE+gSsx2giJPoPmmdEVC4Bram3eobKkf7MH31 MyElV2vSLs5ACi6yJ2O9ozm+rRG0ZtXxISPn+Ce41ESnbJ4EdpROfp9a7j/gZW/BubyV RguIOMrDBZrwzc/F2ZGFd4/RhVLgm1EuNWWukJSQdB4lWH1mmzodu2su16sA/G0wk2Ua UMw7CC0wZJWoTFLw7BudL2VziTKBKkL4zwcKzysdgJ2ssjyGsObG1Bh3bP92YhR43Lq4 zYHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WCLr1NcOcb3nGONEyUolkVCU02HBtDkANd61Ptf8MKg=; b=dHl8VgRhZ0o0ZgNW4OHghY+IrIzmvdy+s824cduRuAHYLxp7SXLfN/GcovL10LZMMM c2GltTvbzdKYNLpt2o6qAH5tosiIJ4Uu0HSHZDTlEZ+RQwl8L2U4HrdyV+T/zK7PI8hG ihE4qLTxVGcdUH0rDB7WSHWN3RzHmCxw1KlJYtMhRKV/zbw2QJ4THbj2sqf6VswtnrMm tMcFcyYuptMN1B6aDldb2CqY/8KI0vYgjRDIQqbXmkxqBEvshAaBSCHFVjYdYBmpgdrP I8rsZOrfOpkjiKfot/kOCihDcacUJsGw0VsnPF00Ko940hFMrIufTuGh5ub0vcQ/Jz+d Am+A== X-Gm-Message-State: AOAM530nWbqWV4NI6e+UnlOskISP69j28Sa45EuF8/OLKRlTkD4+XYLK /6DW+dQXAP0x9oNeS8CfLBOq+H6tTqI= X-Google-Smtp-Source: ABdhPJxTfk1SllBBEPEvt4bWsxLx3NIPsFrke8TQUVDA6lOJXiOea5tcOwiib7AAd4WB57I+MIjD5g== X-Received: by 2002:a17:906:3294:: with SMTP id 20mr20833385ejw.322.1604424608579; Tue, 03 Nov 2020 09:30:08 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id m2sm4532669eds.35.2020.11.03.09.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 09:30:08 -0800 (PST) Date: Tue, 3 Nov 2020 19:30:07 +0200 From: Vladimir Oltean To: Claudiu Manoil Cc: Jakub Kicinski , "netdev@vger.kernel.org" , "David S . Miller" , "james.jurack@ametek.com" Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP Message-ID: <20201103173007.23ttgm3rpmbletee@skbuf> References: <20201029081057.8506-1-claudiu.manoil@nxp.com> <20201103161319.wisvmjbdqhju6vyh@skbuf> <20201103083050.100b2568@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 03, 2020 at 05:18:25PM +0000, Claudiu Manoil wrote: > It's either the dev_kfree_skb_any from the dma mapping error path or the one > from skb_cow_head()'s error path. A confirmation would help indeed. It says "consume", not "kfree", which in my mind would make it point towards the only caller of consume_skb from the gianfar driver, i.e. the dev_consume_skb_any that you just added.