From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF8FC4741F for ; Wed, 4 Nov 2020 08:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71233207BB for ; Wed, 4 Nov 2020 08:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BjJCyAtK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728066AbgKDIwH (ORCPT ); Wed, 4 Nov 2020 03:52:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20359 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgKDIwG (ORCPT ); Wed, 4 Nov 2020 03:52:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604479924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xEUt5EUH16YvaUhu9JLMer/1MWLivZjYY/q1IODAmqs=; b=BjJCyAtK6Pk4VFJY3kALAeNEr3HoRW5WpXvmecYpipVB21usXFtFBCdWu3YYDU1cnS8RgT fvNiPhR8sTi7rkVj4qHNVYw9xhloZ182D7hyk/tsoupgBKhfTR2PBMRjsMT6lzQha1Ta7T rRBXzx7mEpQc/9SnxUxPDobrBUHngWA= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-dpm_DJ5GO26xbfcSWuA49g-1; Wed, 04 Nov 2020 03:52:03 -0500 X-MC-Unique: dpm_DJ5GO26xbfcSWuA49g-1 Received: by mail-pg1-f197.google.com with SMTP id b17so13396932pgd.16 for ; Wed, 04 Nov 2020 00:52:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xEUt5EUH16YvaUhu9JLMer/1MWLivZjYY/q1IODAmqs=; b=SXfLZiajUmtMew1vuuy5skUB4NOnv9Z0JefZ4WjTtdcHBL0jcdU9jqfxODwtPGtlLV qoougXW2sHd9tQSAvCD3qyV+yu4115RXWnBPH87Dq61IOklvaSRkefBA58siWeQ+vgIc 1l7Ubwc7wqr5NObl/L15m2KFVGIilrp69K6FARUSrRRJZA8ggyFdT1gkB6twL11SOuCA 2TRn2sZmrz0d9LMEDJ53U7Fp7zd7RlOc6PJMdDZY0A7oU/fcyk7y0nXERHYedpzUImuF 7AWzXVqP0h078Hwsko+AY986NOEYF/ZfwMvCoD3TM8tEZEmQm8VnxLRFUnHO7kEseeDD Vcww== X-Gm-Message-State: AOAM53383dX5KtPRGuWOQR5L1YC6glu6Y9WuGyXiLKqKPzZ/EhrqxTD5 g5vhcFdsFTr3qrBJArVCDcrRoCjdo5qhZi0hendtJ08xQGMhoCxIQJsYXvOHLxucdQvPD30Gsfi zAQhhw2ldUSkrngU= X-Received: by 2002:a17:90b:1642:: with SMTP id il2mr2678197pjb.81.1604479922129; Wed, 04 Nov 2020 00:52:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCQhWYERz6hxQnPPSTbwhK08O8t2kDESGcVJbn64vjo7BnJ8Ci65snM49uwBfRwT/tIVeA9g== X-Received: by 2002:a17:90b:1642:: with SMTP id il2mr2678176pjb.81.1604479921809; Wed, 04 Nov 2020 00:52:01 -0800 (PST) Received: from dhcp-12-153.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id nh24sm1511767pjb.44.2020.11.04.00.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 00:52:01 -0800 (PST) Date: Wed, 4 Nov 2020 16:51:49 +0800 From: Hangbin Liu To: David Ahern Cc: Stephen Hemminger , Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , David Miller , Jesper Dangaard Brouer , netdev@vger.kernel.org, bpf@vger.kernel.org, Jiri Benc , Andrii Nakryiko , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Subject: Re: [PATCHv3 iproute2-next 1/5] configure: add check_libbpf() for later libbpf support Message-ID: <20201104085149.GQ2408@dhcp-12-153.nay.redhat.com> References: <20201028132529.3763875-1-haliu@redhat.com> <20201029151146.3810859-1-haliu@redhat.com> <20201029151146.3810859-2-haliu@redhat.com> <78c5df29-bf06-0b60-d914-bdab3d65b198@gmail.com> <20201103055419.GI2408@dhcp-12-153.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 03, 2020 at 10:32:37AM -0700, David Ahern wrote: > configure scripts usually allow you to control options directly, > overriding the autoprobe. What do you think of the follow update? It's a little rough and only controls libbpf. $ git diff diff --git a/configure b/configure index 711bb69c..be35c024 100755 --- a/configure +++ b/configure @@ -442,6 +442,35 @@ endif EOF } +usage() +{ + cat <$CONFIG quiet_config >> $CONFIG @@ -476,8 +505,10 @@ check_setns echo -n "SELinux support: " check_selinux -echo -n "libbpf support: " -check_libbpf +if [ -z $NO_LIBBPF_CHECK ]; then + echo -n "libbpf support: " + check_libbpf +fi echo -n "ELF support: " check_elf $ ./configure -h Usage: ./configure [OPTIONS] -h | --help Show this usage info --no-libbpf build the package without libbpf --libbpf-dir=DIR build the package with self defined libbpf dir Thanks Hangbin