From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, dsahern@gmail.com,
jiri@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 14/18] nexthop: Remove in-kernel route notifications when nexthop changes
Date: Wed, 4 Nov 2020 15:30:36 +0200 [thread overview]
Message-ID: <20201104133040.1125369-15-idosch@idosch.org> (raw)
In-Reply-To: <20201104133040.1125369-1-idosch@idosch.org>
From: Ido Schimmel <idosch@nvidia.com>
Remove in-kernel route notifications when the configuration of their
nexthop changes.
These notifications are unnecessary because the route still uses the
same nexthop ID. A separate notification for the nexthop change itself
is now sent in the nexthop notification chain.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
---
net/ipv4/fib_trie.c | 9 ---------
net/ipv6/route.c | 5 -----
2 files changed, 14 deletions(-)
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index ffc5332f1390..28117c05dc35 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -2100,15 +2100,6 @@ static void __fib_info_notify_update(struct net *net, struct fib_table *tb,
rtmsg_fib(RTM_NEWROUTE, htonl(n->key), fa,
KEYLENGTH - fa->fa_slen, tb->tb_id,
info, NLM_F_REPLACE);
-
- /* call_fib_entry_notifiers will be removed when
- * in-kernel notifier is implemented and supported
- * for nexthop objects
- */
- call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE,
- n->key,
- KEYLENGTH - fa->fa_slen, fa,
- NULL);
}
}
}
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7e0ce7af8234..f91a689edafd 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -6039,11 +6039,6 @@ void fib6_rt_update(struct net *net, struct fib6_info *rt,
struct sk_buff *skb;
int err = -ENOBUFS;
- /* call_fib6_entry_notifiers will be removed when in-kernel notifier
- * is implemented and supported for nexthop objects
- */
- call_fib6_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE, rt, NULL);
-
skb = nlmsg_new(rt6_nlmsg_size(rt), gfp_any());
if (!skb)
goto errout;
--
2.26.2
next prev parent reply other threads:[~2020-11-04 13:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 13:30 [PATCH net-next 00/18] nexthop: Add support for nexthop objects offload Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 01/18] nexthop: Add nexthop notification data structures Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 02/18] nexthop: Pass extack to nexthop notifier Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 03/18] nexthop: Prepare new notification info Ido Schimmel
2020-11-06 19:08 ` Jakub Kicinski
2020-11-04 13:30 ` [PATCH net-next 04/18] nexthop: vxlan: Convert to " Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag Ido Schimmel
2020-11-06 19:12 ` Jakub Kicinski
2020-11-09 15:35 ` Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 06/18] nexthop: Allow setting "offload" and "trap" indications on nexthops Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 07/18] nexthop: Emit a notification when a nexthop is added Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 08/18] nexthop: Emit a notification when a nexthop group is replaced Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 09/18] nexthop: Emit a notification when a single nexthop " Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 10/18] nexthop: Emit a notification when a nexthop group is modified Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 11/18] nexthop: Emit a notification when a nexthop group is reduced Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 12/18] nexthop: Pass extack to register_nexthop_notifier() Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 13/18] nexthop: Replay nexthops when registering a notifier Ido Schimmel
2020-11-04 13:30 ` Ido Schimmel [this message]
2020-11-04 13:30 ` [PATCH net-next 15/18] netdevsim: Add devlink resource for nexthops Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 16/18] netdevsim: Add dummy implementation for nexthop offload Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 17/18] netdevsim: Allow programming routes with nexthop objects Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 18/18] selftests: netdevsim: Add test for nexthop offload API Ido Schimmel
2020-11-06 19:31 ` [PATCH net-next 00/18] nexthop: Add support for nexthop objects offload Jakub Kicinski
2020-11-09 15:41 ` Ido Schimmel
2020-11-10 3:48 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104133040.1125369-15-idosch@idosch.org \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).