From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37900C2D0A3 for ; Thu, 5 Nov 2020 01:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA6C2208C7 for ; Thu, 5 Nov 2020 01:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604538971; bh=3r2MutcLvA5vfYMXLE0DmewD6e+qCFh7NdwOTIdnQNQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=C57Mq9JiyxZdvZVN0137Rm4qNNfiZnuNRdAnEpcB/DDCCABNYJslS1c1Sc1U96d/B 5dc0mPZ3Wws6pJy8NLvpXQihPXu2hHOofzqA2rpOZAQfFZmC6F9rz3Cpc+bpGbKFMu I3jUQKrzQVIcygL6GsWt3VslSTtI/LyF1RPeQgXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388258AbgKEBQL (ORCPT ); Wed, 4 Nov 2020 20:16:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:57960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbgKEBQK (ORCPT ); Wed, 4 Nov 2020 20:16:10 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BBED206E3; Thu, 5 Nov 2020 01:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604538970; bh=3r2MutcLvA5vfYMXLE0DmewD6e+qCFh7NdwOTIdnQNQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ziB/nHm8W6P7qa3XOAWj843yTttfuQ7/eTLli6c7E4Km5sWXA/wFfO/XU9FyUDy3z 8qxUO3kmjFsUAdyNjYT9wFdgfHFvGigmMcmxlMRAR+jqVVAGvABVIW7ib1NcvlDn11 2I0jQQh6EnfQOQ37AOmZTgSTUGVGbo3UKeLg6dds= Date: Wed, 4 Nov 2020 17:16:09 -0800 From: Jakub Kicinski To: Vinay Kumar Yadav Cc: netdev@vger.kernel.org, davem@davemloft.net, borisp@nvidia.com, secdev@chelsio.com Subject: Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP Message-ID: <20201104171609.78d410db@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201103104702.798-1-vinay.yadav@chelsio.com> References: <20201103104702.798-1-vinay.yadav@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 3 Nov 2020 16:17:03 +0530 Vinay Kumar Yadav wrote: > user can initialize tls ulp using setsockopt call on socket > before listen() in case of tls-toe (TLS_HW_RECORD) and same > setsockopt call on connected socket in case of kernel tls (TLS_SW). > In presence of tls-toe devices, TLS ulp is initialized, tls context > is allocated per listen socket and socket is listening at adapter > as well as kernel tcp stack. now consider the scenario, connections > are established in kernel stack. > on every connection close which is established in kernel stack, > it clears tls context which is created on listen socket causing > kernel panic. > Addressed the issue by setting child socket to base (non TLS ULP) > when tls ulp is initialized on parent socket (listen socket). > > Fixes: 76f7164d02d4 ("net/tls: free ctx in sock destruct") > Signed-off-by: Vinay Kumar Yadav We should prevent from the socket getting into LISTEN state in the first place. Can we make a copy of proto_ops (like tls_sw_proto_ops) and set listen to sock_no_listen?