From: Po-Hsu Lin <po-hsu.lin@canonical.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, skhan@linuxfoundation.org,
po-hsu.lin@canonical.com
Subject: [PATCH 2/2] selftests: pmtu.sh: improve the test result processing
Date: Thu, 5 Nov 2020 18:50:51 +0800 [thread overview]
Message-ID: <20201105105051.64258-3-po-hsu.lin@canonical.com> (raw)
In-Reply-To: <20201105105051.64258-1-po-hsu.lin@canonical.com>
This test will treat all non-zero return codes as failures, it will
make the pmtu.sh test script being marked as FAILED when some
sub-test got skipped.
Improve the result processing by
* Only mark the whole test script as SKIP when all of the
sub-tests were skipped
* If the sub-tests were either passed or skipped, the overall
result will be PASS
* If any of them has failed, the overall result will be FAIL
* Treat other return codes (e.g. 127 for command not found) as FAIL
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
tools/testing/selftests/net/pmtu.sh | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index fb53987..5c86fb1 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -1652,7 +1652,23 @@ run_test() {
return $ret
)
ret=$?
- [ $ret -ne 0 ] && exitcode=1
+ case $ret in
+ 0)
+ all_skipped=false
+ [ $exitcode=$ksft_skip ] && exitcode=0
+ ;;
+ 1)
+ all_skipped=false
+ exitcode=1
+ ;;
+ $ksft_skip)
+ [ $all_skipped = true ] && exitcode=$ksft_skip
+ ;;
+ *)
+ all_skipped=false
+ exitcode=1
+ ;;
+ esac
return $ret
}
@@ -1786,6 +1802,7 @@ usage() {
#
exitcode=0
desc=0
+all_skipped=true
while getopts :ptv o
do
--
2.7.4
next prev parent reply other threads:[~2020-11-05 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 10:50 [PATCH 0/2] selftests: pmtu.sh: improve the test result processing Po-Hsu Lin
2020-11-05 10:50 ` [PATCH 1/2] selftests: pmtu.sh: use $ksft_skip for skipped return code Po-Hsu Lin
2020-11-05 10:50 ` Po-Hsu Lin [this message]
2020-11-07 23:02 ` [PATCH 2/2] selftests: pmtu.sh: improve the test result processing Jakub Kicinski
2020-11-09 3:42 ` Po-Hsu Lin
2020-11-09 18:09 ` Jakub Kicinski
2020-11-10 1:36 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105105051.64258-3-po-hsu.lin@canonical.com \
--to=po-hsu.lin@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).