From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3IGW=EM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E5D5CC2D0A3
	for <netdev@archiver.kernel.org>; Fri,  6 Nov 2020 19:08:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 7945E2151B
	for <netdev@archiver.kernel.org>; Fri,  6 Nov 2020 19:08:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1604689734;
	bh=7sSY9kAdbqrmi1M8SMkcEMDihClhK4d0ljNbvb7lMOE=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=zvSiMgELqqlz8jIBa2ulLMHsoL0+sEXRIK4/wGEn591qzYaGbyDtbyWqZzF25cvO7
	 uq3RvsfQt1YDtg1aGUbs/vwCAr0dpKTjeMhb08glNfygpX6LkMR9wQTcZW+dXc+1kR
	 uA6BN34JguKiH7mcma4UDaHME95czl9lr5du8l1c=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727912AbgKFTIx (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 6 Nov 2020 14:08:53 -0500
Received: from mail.kernel.org ([198.145.29.99]:56296 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725868AbgKFTIx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 6 Nov 2020 14:08:53 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 5C3B9208C7;
        Fri,  6 Nov 2020 19:08:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1604689732;
        bh=7sSY9kAdbqrmi1M8SMkcEMDihClhK4d0ljNbvb7lMOE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Y2gtZex0DMFjmhwz1mXhIn4s5elNT/h70ZsMUcM8olSeLoyMIIPtvJIHqnik00HyK
         dDqhwCFTtg5xPRQREKS5W9IGxPPRzATSzKzMOTGYrGRPZ1HOvnQxdIY1hvlZrtIxZK
         inm5aVocGf9SxRMAykTWjvdgNSkfxt/l+XcB4VNk=
Date:   Fri, 6 Nov 2020 11:08:51 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, dsahern@gmail.com,
        jiri@nvidia.com, mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next 03/18] nexthop: Prepare new notification info
Message-ID: <20201106110851.1467a90f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201104133040.1125369-4-idosch@idosch.org>
References: <20201104133040.1125369-1-idosch@idosch.org>
        <20201104133040.1125369-4-idosch@idosch.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed,  4 Nov 2020 15:30:25 +0200 Ido Schimmel wrote:
> +	if (info->is_grp)
> +		return nh_notifier_grp_info_init(info, nh);
> +	else
> +		return nh_notifier_single_info_init(info, nh);

nit: please try to avoid unnecessary else branches, it obviously
     doesn't matter but people send patches to refactor this :(