From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260D7C388F9 for ; Fri, 6 Nov 2020 22:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0C1D20882 for ; Fri, 6 Nov 2020 22:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604702782; bh=i44Y1P6laXQjWocSVI8b/5WYJYlsz/UZcBJas/yMZ2o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bMs9T6W2Y//W95Arj2gyfcLWGGnLhk8NiOAcsVWcjRfWIfJhibb3lpmtFC+P+L8G5 FSue58CRSlh/cfj3yUtBYadTz4p5mHTGnIpHJCyYBgK0caxk7gEfpQ14RlrN8P+7Wf RqAx9KY5g/XouIm3NpX+uguy2BmPxPIWN49lrFkM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728931AbgKFWqT (ORCPT ); Fri, 6 Nov 2020 17:46:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:48568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgKFWqT (ORCPT ); Fri, 6 Nov 2020 17:46:19 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EDDA2087E; Fri, 6 Nov 2020 22:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604702778; bh=i44Y1P6laXQjWocSVI8b/5WYJYlsz/UZcBJas/yMZ2o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vth4ShWnNCxOWPEYFhf2r43v524rF425f5RaFDqL1jI6vPTRji6+99tlSgsuppDdN /lZ1qgzzWP8y94lmybwD/UTorsvVJCGuEZ0G1FglkDHJv32wAsSaxM+fAQSOGBfVlZ zOzeyCqGfqnU5vD5rlKtU6Yp2v6YjJGLAoAHeUiI= Date: Fri, 6 Nov 2020 14:46:16 -0800 From: Jakub Kicinski To: Arnd Bergmann Cc: Networking , Arnd Bergmann , "David S. Miller" , Christoph Hellwig , Jiri Pirko , Taehee Yoo , Eric Dumazet , Alexei Starovoitov , Andrew Lunn , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3 0/4] remove compat_alloc_user_space() Message-ID: <20201106144616.28d074a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201106173231.3031349-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 6 Nov 2020 22:48:18 +0100 Arnd Bergmann wrote: > On Fri, Nov 6, 2020 at 6:32 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > This is the third version of my seires, now spanning four patches > > instead of two, with a new approach for handling struct ifreq > > compatibility after I realized that my earlier approach introduces > > additional problems. > > > > The idea here is to always push down the compat conversion > > deeper into the call stack: rather than pretending to be > > native mode with a modified copy of the original data on > > the user space stack, have the code that actually works on > > the data understand the difference between native and compat > > versions. > > > > I have spent a long time looking at all drivers that implement > > an ndo_do_ioctl callback to verify that my assumptions are > > correct. This has led to a series of 29 additional patches > > that I am not including here but will post separately, fixing > > a number of bugs in SIOCDEVPRIVATE ioctls, removing dead > > code, and splitting ndo_do_ioctl into two new ndo callbacks > > for private and ethernet specific commands. > > I got a reply from the build bots that the version I sent was broken > on 32-bit machines, so don't merge it just yet. Let me know if > there are any other comments I should address before resending > though. Looks like patch 4 also breaks 64 bit allmodconfig build. Beyond that - patches 1 and 4 warrant need a second look at: checkpatch.pl --strict --min-conf-desc-length=80